tighten node_version test code

segments/node_version/node_version.spec

@@ -8,13 +8,15 @@ SHUNIT_PARENT=$0
 function oneTimeSetUp() {
   export TERM="xterm-256color"
 
-  OLDPATH="${PATH}"
-  PATH="${NODE_VERSION_TEST_FOLDER}:${PATH}"
-
   OLD_DIR="${PWD}"
 
   TEST_BASE_FOLDER="/tmp/powerlevel9k-test"
   NODE_VERSION_TEST_FOLDER="${TEST_BASE_FOLDER}/node_version-test"
+
+  OLDPATH="${PATH}"
+  PATH="${NODE_VERSION_TEST_FOLDER}:${PATH}"
+
+  P9K_CUSTOM_WORLD='echo world'
 
   node() {
     echo "v1.2.3"
@@ -46,14 +48,11 @@ function oneTimeTearDown() {
 }
 
 function testNodeVersionSegmentWorks() {
-  P9K_NODE_VERSION_PROJECT_ONLY=false
-
   assertEquals "%K{002} %F{015}⬢ %F{015}1.2.3 %k%F{002}%f " "$(__p9k_build_left_prompt)"
 }
 
 function testNodeVersionSegmentPrintsNothingWithoutNode() {
-  P9K_LEFT_PROMPT_ELEMENTS=(node_version custom_world)
-  local P9K_CUSTOM_WORLD='echo world'
+  P9K_LEFT_PROMPT_ELEMENTS+=(custom_world)
 
   alias node="nonode 2>/dev/null"
 
@@ -63,8 +62,7 @@ function testNodeVersionSegmentPrintsNothingWithoutNode() {
 }
 
 function testNodeVersionSegmentProjectOnlyPrintsNothingOutsideProjectDirectory() {
-  P9K_LEFT_PROMPT_ELEMENTS=(node_version custom_world)
-  local P9K_CUSTOM_WORLD='echo world'
+  P9K_LEFT_PROMPT_ELEMENTS+=(custom_world)
 
   P9K_NODE_VERSION_PROJECT_ONLY=true
 
@@ -77,8 +75,6 @@ function testNodeVersionSegmentProjectOnlyWorksInsideProjectDirectory() {
   touch ./package.json
 
   assertEquals "%K{002} %F{015}⬢ %F{015}1.2.3 %k%F{002}%f " "$(__p9k_build_left_prompt)"
-
-  rm ./package.json
 }
 
 function testNodeVersionSegmentProjectOnlyWorksInsideProjectChildDirectory() {
@@ -89,9 +85,6 @@ function testNodeVersionSegmentProjectOnlyWorksInsideProjectChildDirectory() {
   cd test-child
 
   assertEquals "%K{002} %F{015}⬢ %F{015}1.2.3 %k%F{002}%f " "$(__p9k_build_left_prompt)"
-
-  cd ..
-  rm ./package.json
 }
 
 source shunit2/shunit2