Skip to content
This repository has been archived by the owner on Apr 24, 2020. It is now read-only.

Fix: bad math expression #1184

Closed
wants to merge 1 commit into from
Closed

Conversation

paleite
Copy link

@paleite paleite commented Mar 9, 2019

When grep is set to --color=always (e.g. by specifying alias grep="grep --color=always"), the script didn't take them into account. This is likely the cause of #1092.

This PR changes all instances of grep (and egrep) to use --color=never.

When `grep` is set to `--color=always` (e.g. by specifying `alias grep="grep --color=always`), the script didn't take them into account. This is likely the cause of Powerlevel9k#1092.

This PR changes all instances of `grep` (and `egrep`) to use `--color=never`.
iilonmasc added a commit to iilonmasc/powerlevel9k that referenced this pull request Mar 14, 2019
@iilonmasc
Copy link
Member

iilonmasc commented Mar 14, 2019

Thanks for your PR @paleite ! I've added your fix or rather the idea to my PR #1198 as well because I am using egrep in a new function.

@paleite
Copy link
Author

paleite commented Mar 17, 2019

That’s awesome, @sambadevi 👍🙂

@paleite paleite closed this Mar 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants