Refactor storage and preferences usage across app #714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centralizes Hive box and SharedPreferences key management via new app_storage utility. Updates all references to use constants and helper methods, improving maintainability and reducing hardcoded strings. Refactors layout config, location, and cache access patterns, and applies minor code style and widget improvements throughout. Also updates Gradle and Android plugin versions.
Owner
|
@NullVerdict This is a pretty big refactor. It’ll take some time to review and test, since I’m busy with other projects. If I get the time, I’ll take a proper look. Thanks :P |
added 4 commits
December 21, 2025 12:28
Refactored LayoutProvider and Home screen to optimize layout config and weather data caching, reducing unnecessary rebuilds and improving performance. Added derived weather data caching and insights data memoization. Updated package dependencies, replacing flutter_markdown with flutter_markdown_plus and bumping several package versions. Fixed a UI label in current_conditions_card and improved HourlyCard's start index logic.
Standardized widget provider and config activity class names to PascalCase in both Kotlin and XML, updated references throughout the codebase, and improved code consistency in Dart controllers and screens. Refactored gradient logic, extracted constants, and enhanced readability in several Dart files. Also made minor UI and logic improvements for better maintainability.
Replaced hive and hive_flutter with hive_ce and hive_ce_flutter throughout the codebase. Refactored asset paths for weather icons and animations to use base path constants. Improved async handling for background updates and widget updates by adding missing awaits. Removed lat_lng_to_timezone dependency and replaced timezone logic with a constant. Enhanced weather service HTTP client management and error handling. Updated pubspec.yaml and removed unused imports.
Refactored WeatherConditionAnimationMapper for improved readability and maintainability, including switch-based weather type resolution and a new _lottieLayer helper. In current_conditions_card.dart, consolidated unit conversions, improved tile tap handling, reduced code duplication, and enhanced null/data checks for better user feedback and maintainability.
Author
|
Overall, if it stays open for another week, I’ll be forced to close it. Another dead project. |
Owner
|
@NullVerdict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centralizes Hive box and SharedPreferences key management via new app_storage utility. Updates all references to use constants and helper methods, improving maintainability and reducing hardcoded strings. Refactors layout config, location, and cache access patterns, and applies minor code style and widget improvements throughout. Also updates Gradle and Android plugin versions.