Refactor WeatherHome to process data outside build method #721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved expensive data processing (date parsing, loops for filtering hours, rain logic) out of the `build` method in `lib/screens/home.dart`. Created `WeatherDisplayData` model to hold processed data. Updated `FutureBuilder` to use pre-calculated data. This reduces CPU usage on every rebuild of the home screen.
Owner
|
@harrydbarnes Looks good, did you test the refactor on-device/emulator to make sure the UI still updates normally and nothing breaks? |
PranshulGG
added
the
waiting for feedback
Author
@PranshulGG Built out an apk now and will test. Had the below error during setup when trying to use current location. Used import backup and was fine. Do you see this error at all? Error: |
Owner
|
@harrydbarnes I don’t see this error, it’s probably an API issue or something similar. I’ll try to include this PR in the next release after some testing :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved expensive weather data processing logic out of the
buildmethod inlib/screens/home.dart. Previously, the app was parsingDateTimestrings and iterating over large lists (hourly data) on every frame/rebuild of the home screen.Changes:
lib/models/weather_display_data.dartto hold pre-processed view data.processWeatherDatafunction to handle data transformation once.WeatherHometo fetch and process data asynchronously, passing the ready-to-use object to the UI.