Handle Windows npx detection when npx.cmd is missing#3416
Open
Handle Windows npx detection when npx.cmd is missing#3416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
_get_npx_command()probednpx.cmd,npx.exe, andnpxusingsubprocess.run(..., shell=False), but only caughtsubprocess.CalledProcessError, so a missing executable raisedFileNotFoundErrorand aborted the probe early instead of falling back to the next candidate.Description
FileNotFoundErrorin the same except block asCalledProcessError, and add a focused unit testtest_get_npx_command_windows_cmd_missingthat simulatesFileNotFoundErrorfornpx.cmdand verifies fallback tonpx.exe.Before/after (conceptual):
except subprocess.CalledProcessError:->except (subprocess.CalledProcessError, FileNotFoundError):Testing
uv sync(succeeded), ran the full test suiteuv run pytest -n auto(environment showed unrelated timeouts/integration failures outside this CLI change), and ran the focused CLI tests withuv run pytest tests/cli/test_cli.py -k npx_commandwhich passed (6 passed);uv run prek run --all-filesfailed to init hooks due to external network access to a git dependency.Codex Task