Repository navigation
fix(client): Await the in-flight stdio session after a cancelled connect waiter - #5545
Closed
mikamikasuki wants to merge 1 commit into
Closed
mikamikasuki wants to merge 1 commit into
mikamikasuki wants to merge 1 commit into
Conversation
Retain the in-flight ClientSession future on StdioTransport so a later caller can await a connection whose first connect_session waiter was cancelled. Reset the future during disconnect and preserve the existing return behavior for ready keep-alive sessions. 🤖 Generated with OpenAI Codex
Contributor
|
This pull request was closed because it needs a valid issue link. Please update this PR rather than opening a new one. Per CONTRIBUTING.md, an external PR must reference an issue that's assigned to its author. To get there:
Once you're assigned and the link is present, this check is re-run automatically. Previously gate-closed PRs also reopen — no further action needed. Maintainers: reopen this PR or remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Retain the in-flight
ClientSessionfuture onStdioTransportso a laterconnect_session()caller can await startup after the original waiter is cancelled. Clear it on disconnect and preserve the existing ready-sessionconnect()behavior.Closes #
Contribution type
Checklist
uv run prek run --all-filesand all checks pass