-
Notifications
You must be signed in to change notification settings - Fork 31
Ability to open a link as a popup window #38
base: dev
Are you sure you want to change the base?
Conversation
@@ -52,7 +52,7 @@ public function __construct() | |||
{ | |||
$this->name = 'blocktopmenu'; | |||
$this->tab = 'front_office_features'; | |||
$this->version = '2.2.2'; | |||
$this->version = '2.3'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Thank you for your PR. No need to uupdate version number in your PR, thank you.
Regards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Fri, Aug 07, 2015 at 02:31:25AM -0700, Gregory Roussac wrote:
@@ -52,7 +52,7 @@ public function __construct()
{
$this->name = 'blocktopmenu';
$this->tab = 'front_office_features';
$this->version = '2.2.2';
$this->version = '2.3';
ok.
But how to name the update function then ? It should take the name of
the next version it will apply to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
The merger will adapt the file when he will create a new master version if necessary.
Regards
The window dimensions are hardcode at the moment, but at least it gives webmaster a place to modify these settings while getting the basic working feature already implemented.
updated ... using --amend + forced push |
Could we discuss how to enhance the feature so that it get a chance to be pushed and everyone may enjoy it.
Then one generic but still easy to implement option is optionnal sprintf()-style string input text where placerholders may be used to represent link anchor, link name, menu id, ... comments? |
On some of my links I needs,
|
pull request #43 is the way to go |
Ability to open a link as a popup window
The window dimensions are still hardcoded at the moment, but at least it gives
webmaster a place to modify these UI settings while getting the basic working feature
already implemented.