Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check PHP max version compatibility #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Check PHP max version compatibility #33

wants to merge 1 commit into from

Conversation

Klemart3D
Copy link

Questions Answers
Description? Add a way to check if a PHP version can be too new for PrestaShop
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #32
How to test? PHP version ≥8.2 must display a cell with red background

Tests :

PHP 8.2 is incompatible:
php_8 2

PHP 8.1 is OK:
php_8 1

PHP 7.4 is required but not recommended:
php_7 4

matks
matks requested changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for late answer

It would then only work for PS8? Because PS9 is compatible with PHP8.2 and PHP8.3

@Klemart3D
Copy link
Author

Perhaps must be updated for PS9 with "PHP 8.3" when v9.0 will be officially released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matks matks matks requested changes

Assignees
No one assigned
Labels
Waiting for author
Projects
PR Dashboard
Status: Waiting for author
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check max PHP version compatibility
3 participants
@Klemart3D @matks @ps-jarvis