[Codencode]

Questions	Answers
Description?
Type?	improvement
BC breaks?	no
Deprecations?	no
Fixed ticket?
Sponsor company	Condencode
How to test?

---

IMPORTANT NOTE

This PR is affected by the same issue as ps_apiresources#82

This PR needs these PRs to work:

• Fix grid doctrine query builder to use context language instead of employee language PrestaShop#39669
• Fix: make /attachments/{attachmentId} endpoint work by adding AttachmentId to EditableAttachment and renaming attachmentIdValue to attachmentId in GetAttachmentForEditing PrestaShop#39966

The integration tests failures are due to the absence of PR PrestaShop/PrestaShop#39966.

[boherm]

Hi @Codencode!
Is this PR still blocked by core? 🤔

[Codencode]

Hi @boherm,
I think so, because in my opinion making this work required a core change. That’s why I opened this PR: PrestaShop/PrestaShop#39966

In this comment (PrestaShop/PrestaShop#39966 (comment)) I asked for feedback, but I didn’t receive any response.

Later, after the release of version 9.1.1, rebasing became necessary. I can do that, but before proceeding I’d prefer to understand whether this PR is actually needed or whether there is an alternative way to make it work.

[boherm]

Hum, after checking your PR, I think that you can reopened it for 9.1.x 🤔
The main problem that I see:
This ps_apiresource module need to be working from 9.0 to develop and if we fix this for 9.1 we made attachment endpoints nonfunctional with 9.0. BUT, we can only push security fixes in 9.0 but not this kind of fix... 🤔

(As we have a lot of notifications, we can't see all PRs 😭)

[Codencode]

@boherm

Hum, after checking your PR, I think that you can reopened it for 9.1.x 🤔
The main problem that I see:
This ps_apiresource module need to be working from 9.0 to develop and if we fix this for 9.1 we made attachment endpoints nonfunctional with 9.0. BUT, we can only push security fixes in 9.0 but not this kind of fix... 🤔

So how should we proceed?
In your opinion, is there no alternative to the PR in the core?
I remember that when I implemented this PR, I didn't find any alternatives.

(As we have a lot of notifications, we can't see all PRs 😭)

Don't worry, I imagine it's not a concern for you!

[Codencode]

Close in favour of: #295