Repository navigation
Conversation
Expose CRUD for carriers: GET/POST/PATCH/DELETE /carriers. Create and update accept a multipart logo upload alongside the carrier fields, localized delay, associated groups/shops and zones. Wires to the existing CQRS (AddCarrierCommand/EditCarrierCommand/GetCarrierForEditing/ DeleteCarrierCommand). Carrier ranges remain a follow-up (separate SetCarrierRangesCommand). Contributes to #39630.
|
Hello @boo-code! This is your first pull request on ps_apiresources repository of the PrestaShop project. Thank you, and welcome to this Open Source community! |
Author
Closed
github-project-automation
Bot
moved this from Ready for review
to Closed
in PR Dashboard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET/POST/PATCH/DELETE /carriers. Create and update accept a multipartlogoFileupload alongside the carrier fields (name, localizeddelay, grade, tracking URL, dimensions/weight, shipping method, range behavior, free/handling-fee flags), the associated customer groups and shops, and the zones. Wires to the existing CQRS (AddCarrierCommand,EditCarrierCommand,GetCarrierForEditing,DeleteCarrierCommand). Carrier ranges (weight/price ranges) are intentionally left as a follow-up since they are managed through a separateSetCarrierRangesCommand. Covered byCarrierEndpointTest— full CRUD incl. multipart logo — 8 tests / 41 assertions green against the local integration harness.CarrierEndpointTest. Or POST a multipart request to/carrierswithlogoFile,name,delay[<locale>],zones[],associatedGroupIds[],associatedShopIds[],shippingMethod,rangeBehavior, etc.; then GET/PATCH/DELETE/carriers/{id}.