Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GH workflows: Node 14-16, PHP 7.2-8.2, Github actions v3 #902

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

leemyongpakvn
Copy link
Contributor

@leemyongpakvn leemyongpakvn commented Aug 15, 2023

Questions Answers
Description? Recent PRs' tests have a lot of warnings about outdated Node, GH actions
(9 JS warnings and 21 PHP warnings in Release v3.13.1):
https://github.com/PrestaShop/ps_facetedsearch/actions/runs/5793944220
https://github.com/PrestaShop/ps_facetedsearch/actions/runs/5793944222
Type? improvement
BC breaks? no
Deprecations? yes
Fixed ticket? Fixes PrestaShop/Prestashop#{issue number here}.
How to test? GH workflows complete with less warnings about outdated Node, PHP, actions.

This change is Reviewable

@leemyongpakvn
Copy link
Contributor Author

@Hlavtox Feel free to bump minimum compatibility to PHP 7.1.3 and PS 1.7.7, module version to 4.0.0 as we agreed at issues/32841 when you think it's the right time.

LouisAUTHIE
LouisAUTHIE previously approved these changes Aug 16, 2023
@aniszr aniszr added the waiting for dev waiting for dev label Aug 17, 2023
@kpodemski kpodemski added this to the 3.13.2 milestone Aug 22, 2023
Copy link
Contributor

@kpodemski kpodemski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @leemyongpakvn

In order for CI to be helpful for this module, let's consider this scenario:

  • from now on we would check only for PHP 7.2 to 8.2 compatibility whereas the module is still compatible with PrestaShop 1.7.6 which should work with as low as PHP 5.6. Even PrestaShop 1.7.7 supports PHP 7.1+, so either we should have tests for PHP 7.1+, or we should bump the compatibility to PrestaShop 8.

@ps-jarvis ps-jarvis added the waiting for author Waiting for author's feedback label Aug 22, 2023
@leemyongpakvn
Copy link
Contributor Author

@kpodemski As we can see in Files changed, this repo lacks of PHP 7.1 check for a long time, not after this PR. I suggested matks add it himself in Slack but he forgot or has no time to do ;) Added by the way.

@kpodemski kpodemski merged commit c358649 into PrestaShop:dev Aug 22, 2023
11 checks passed
@kpodemski
Copy link
Contributor

thanks @leemyongpakvn

the next step it to drop support for 1.7.6

@kpodemski kpodemski removed Waiting for QA waiting for author Waiting for author's feedback waiting for dev waiting for dev labels Aug 22, 2023
@leemyongpakvn leemyongpakvn deleted the update_Node_PHP_GHactions branch November 21, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants