Asset files: search for license at the start of the file #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a comment in the middle of your file that resembles a license comment syntax (which, from what I tested, it applies to most asset files except for twig which has slightly different syntax for comments), then the license comment doesn't get added to that file. I've stumbled upon this issue when I had
{* This is HTML content *}comments in my smarty files.The fix is very simple, I just added
^to the comment regex so it only searches from the beginning of the file's contents.This change only affects asset files (css, js, tpl, twig etc.) since for PHP there is a separate method for handling the license comment.