Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: reafactoring makefile and packaging #430

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

chore: reafactoring makefile and packaging #430

wants to merge 32 commits into from

Conversation

jokesterfr
Copy link
Contributor

@jokesterfr jokesterfr commented Aug 12, 2024 •
edited
Loading

Changes

  • Rely on php-scoper's phar instead of docker
  • Ignore php-scoper phar and MAC stuff
  • Update composer's lockfile
  • Updated the github actions workflow
  • PHPUnit works locally and in docker
  • PHPStan works locally and in docker
  • PHP CS Fixer fixed all source code (via PHP 8 ou PHP plus ancien ?)
  • E2E tests passed
  • Est-il possible d'empêcher l'upgrade du module lors de l'install ? Dans les init-scripts ? Un update en bdd en 99.99.99?
  • Keep the Herve's way of coding with TDD: the IDE should be plugged to the phpunit tests
  • Split PHP unit tests: unit testing and feature testing

@jokesterfr jokesterfr self-assigned this Aug 12, 2024
@jokesterfr jokesterfr changed the title fix/make packaging feat/reafactoring: makefile and packaging Aug 13, 2024
@jokesterfr jokesterfr changed the title feat/reafactoring: makefile and packaging feat: reafactoring makefile and packaging Aug 13, 2024
@jokesterfr jokesterfr changed the title feat: reafactoring makefile and packaging chore: reafactoring makefile and packaging Aug 13, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 27, 2024
View reviewed changes
e2e-env/docker-compose.yml Fixed Show fixed Hide fixed
e2e-env/server-mock/Dockerfile Fixed Show fixed Hide fixed
@jokesterfr jokesterfr added enhancement New feature or request quality assurance needed Trigger continuous deployment integration fix and removed ready to review labels Aug 30, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 30, 2024

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

jokesterfr
jokesterfr commented Sep 4, 2024
View reviewed changes
Makefile
autoindex: ${TOOLS}
autoindex prestashop:add:index "${WORKDIR}"

# target: header-stamp - Add header stamp to files
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.phony manquant

jokesterfr
jokesterfr commented Sep 4, 2024
View reviewed changes
Makefile
php-scoper: ${WORKDIR}/vendor ${WORKDIR}/vendor/.scoped

# target: autoindex - Automatically add index.php to each folder (fix for misconfigured servers)
autoindex: ${TOOLS}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.phony manquant

jokesterfr
jokesterfr commented Sep 4, 2024
View reviewed changes
Makefile
header-stamp: ${TOOLS}
header-stamp --target="${WORKDIR}" --license="assets/afl.txt" --exclude=".github,node_modules,vendor,tests,_dev"

# target: version - Update the version in various files
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.phony manquant

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 21, 2024
View reviewed changes
e2e-env/docker-compose.yml
environment:
- MYSQL_HOST=mysql
- MYSQL_USER=prestashop
- MYSQL_PASSWORD=prestashop

Check failure

Code scanning / SonarCloud

MySQL database passwords should not be disclosed High

Make sure this MySQL database password gets changed and removed from the code. See more on SonarCloud
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 30, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
E Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hschoenenberger hschoenenberger Awaiting requested review from hschoenenberger

@antoinemetifeu antoinemetifeu Awaiting requested review from antoinemetifeu

Assignees

@jokesterfr jokesterfr

Labels
enhancement New feature or request fix quality assurance needed Trigger continuous deployment integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jokesterfr @antoinemetifeu