improvement: fix #186 [accordion] add props for paddings #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattgoud
requested review from
fox-john,
FrancoisQtr and
cnavarro-prestashop
Comment on lines
+38
to
+101
| headerPaddingX: { | ||
| control: 'select', | ||
| options: ['smaller', 'small', 'normal', 'large', 'larger'], | ||
| description: 'Set horizontal paddings of accordion header', | ||
| table: { | ||
| defaultValue: { | ||
| summary: 'large', | ||
| detail: 'large (24px)', | ||
| }, | ||
| type: { | ||
| summary: paddingVariantsSummary, | ||
| detail: | ||
| 'smaller(4px) | small(8px) | normal(16px)| large(24px) | larger(32px)', | ||
| }, | ||
| }, | ||
| }, | ||
| headerPaddingY: { | ||
| control: 'select', | ||
| options: ['smaller', 'small', 'normal', 'large', 'larger'], | ||
| description: 'Set vertical paddings of accordion header', | ||
| table: { | ||
| defaultValue: { | ||
| summary: 'normal', | ||
| detail: 'normal(16px)', | ||
| }, | ||
| type: { | ||
| summary: paddingVariantsSummary, | ||
| detail: | ||
| 'smaller(4px) | small(8px) | normal(16px)| large(24px) | larger(32px)', | ||
| }, | ||
| }, | ||
| }, | ||
| contentPaddingX: { | ||
| control: 'select', | ||
| options: ['smaller', 'small', 'normal', 'large', 'larger'], | ||
| description: 'Set horizontal paddings of accordion content', | ||
| table: { | ||
| defaultValue: { | ||
| summary: 'large', | ||
| detail: 'large (24px)', | ||
| }, | ||
| type: { | ||
| summary: paddingVariantsSummary, | ||
| detail: | ||
| 'smaller(4px) | small(8px) | normal(16px)| large(24px) | larger(32px)', | ||
| }, | ||
| }, | ||
| }, | ||
| contentPaddingY: { | ||
| control: 'select', | ||
| options: ['smaller', 'small', 'normal', 'large', 'larger'], | ||
| description: 'Set vertical paddings of accordion content', | ||
| table: { | ||
| defaultValue: { | ||
| summary: 'normal', | ||
| detail: 'normal(16px)', | ||
| }, | ||
| type: { | ||
| summary: paddingVariantsSummary, | ||
| detail: | ||
| 'smaller(4px) | small(8px) | normal(16px)| large(24px) | larger(32px)', | ||
| }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
I think we've to use tokens set up in global PUIK project. Currently we're using Tailwind's token like p-5 or ml-5. @FrancoisQtr your point of view ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
possibility for the user to modify the header and content paddings
❓ Types of changes
New Props :
available values for props above:
"smaller" (4px)
"small" (8px)
"normal" (16px) => default value for vertical paddings
"large" (24px), => default value for horizontal paddings
"larger" (32px)
📖 Documentation (updates to the documentation or readme)
🐞 Bug fix (a non-breaking change that fixes an issue)
👌 Enhancement (improving an existing functionality)
📦 New feature (a non-breaking change that adds functionality)
📝 Checklist