-
Notifications
You must be signed in to change notification settings - Fork 2.3k
1. default to compiled agent installs on macos and linux #2140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+2,007
−27
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
dee40cc
feat: ship standalone macos and linux agent archives
kevinjosethomas 60afc26
ci: isolate standalone builds and support native Python setup
kevinjosethomas 224d7ef
refactor: simplify standalone build inputs
kevinjosethomas 85a9fa9
feat: default to verified compiled installations
kevinjosethomas c84c350
fix: validate the installer command basename
kevinjosethomas b949bb1
fix: preserve concurrent installs and repair native assets
kevinjosethomas b5de63f
fix: recheck public command ownership before activation
kevinjosethomas 03834ad
fix: clean up interrupted installers and expose platform checks
kevinjosethomas 59601c7
fix: create public native links without overwriting commands
kevinjosethomas b1a0b0f
fix: preserve installs of npm-only releases (fixes #2140)
kevinjosethomas e65d802
fix: retain rollback targets during interrupted activation (fixes #2140)
kevinjosethomas dace71f
fix: detect npm-only releases before native ownership checks (fixes #…
kevinjosethomas 9af6bd0
fix: allow repeated Node fallback installs (fixes #2140)
kevinjosethomas 4776940
fix: activate fresh installs before exposing command (fixes #2140)
kevinjosethomas ffe5b81
fix: require HTTPS for standalone downloads (fixes #2140)
kevinjosethomas ccbc3c9
test: name installer coverage by release format; fixes #2140
kevinjosethomas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| name: Standalone binaries | ||
|
|
||
| on: | ||
| workflow_call: | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| build: | ||
| name: Standalone (${{ matrix.platform }}) | ||
| runs-on: ${{ matrix.runner }} | ||
| timeout-minutes: 20 | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - platform: darwin-arm64 | ||
| runner: macos-15 | ||
| - platform: darwin-x64 | ||
| runner: macos-15-intel | ||
| - platform: linux-arm64 | ||
| runner: ubuntu-24.04-arm | ||
| - platform: linux-x64 | ||
| runner: ubuntu-24.04 | ||
| steps: | ||
| - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 | ||
| with: | ||
| persist-credentials: false | ||
| path: source | ||
|
|
||
| - uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 | ||
| with: | ||
| node-version: '22' | ||
| package-manager-cache: false | ||
|
|
||
| - uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2 | ||
| with: | ||
| bun-version: '1.4.0' | ||
| no-cache: true | ||
|
|
||
| - uses: astral-sh/setup-uv@94527f2e458b27549849d47d273a16bec83a01e9 # v7 | ||
| with: | ||
| version: '0.11.7' | ||
| enable-cache: false | ||
|
|
||
| - name: Install native development dependencies | ||
| if: runner.os == 'Linux' | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y libcairo2-dev libpango1.0-dev libjpeg-dev libgif-dev librsvg2-dev | ||
|
|
||
| - name: Install locked npm dependencies | ||
| working-directory: source | ||
| run: npm ci | ||
|
|
||
| - name: Compile standalone application | ||
| working-directory: source/packages/coding-agent | ||
| run: npm run build:binary | ||
|
|
||
| - name: Assemble native archive | ||
|
github-advanced-security[bot] marked this conversation as resolved.
Fixed
|
||
| working-directory: source | ||
| run: | | ||
| version=$(node -p "require('./package.json').version") | ||
| node scripts/assemble-release-archives.mjs packages/coding-agent/binaries "$RUNNER_TEMP/standalone" "$version" | ||
| echo "PRIME_AGENT_TEST_ARCHIVE=$RUNNER_TEMP/standalone/prime-agent-$version-${{ matrix.platform }}.tar.gz" >> "$GITHUB_ENV" | ||
| echo "PRIME_AGENT_TEST_UV=$(command -v uv)" >> "$GITHUB_ENV" | ||
|
|
||
| - name: Remove the build paths from the test machine | ||
| run: mv "$GITHUB_WORKSPACE/source" "$RUNNER_TEMP/standalone-source" | ||
|
|
||
| - name: Test extracted application without JavaScript runtimes on PATH | ||
| working-directory: ${{ runner.temp }}/standalone-source/packages/coding-agent | ||
| run: npx tsx ../../node_modules/vitest/dist/cli.js --run test/compiled-artifact.test.ts test/native-installer.test.ts | ||
|
|
||
| - uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7 | ||
| with: | ||
| name: standalone-${{ matrix.platform }} | ||
| path: | | ||
| ${{ runner.temp }}/standalone/*.tar.gz | ||
| ${{ runner.temp }}/standalone/SHA256SUMS | ||
| if-no-files-found: error | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.