fix benchmark startup and cleanup checks - #2253
Conversation
Follow-up to #2248; refs ENG-6119.
Prime Agent performance — failedPR Overall: 0 regressed · 0 improved · 2 no clear change · 15 unavailable.
Python runtime
Sandbox cost: ~$0.1944 — no inference calls. Methodology and samplesMain resolved at 2026-09-12T01:36:31.324376+00:00. Harness
Failures:
|
Fixes #2253; refs ENG-6119.
The new prompt bar changed the text that our startup benchmark waits for, so both main and the Bun PRs time out even after the application is ready. Some runs also lose a sample when a session exits between being listed and stopped.
This recognizes both prompt layouts and still checks that typing works without submitting a prompt. Cleanup accepts an already-exited session only when the stop command reports that exact missing session and a fresh list confirms it is gone. Other stop failures still fail the benchmark.
Tested both prompt layouts and reproduced the cleanup race in Linux sandboxes. With the fixes, the full Node.js-versus-Bun benchmark passed all measurements: three installs and ten startup/runtime trials per side, with no failures. All 44 benchmark tests and repository checks also pass. This must land on main before GitHub's trusted benchmark runs can use it.
ENG-6119