exclude top k from max vio calculation to try and skip the "padding experts" #1332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Updates
get_load_balance_statsto optionally ignore top-k routed experts (avoiding padding experts) when computing max violation, with proper buffer reset.src/prime_rl/trainer/model.py):try_to_avoid_padding_experts: bool = Truetoget_load_balance_stats.mlp.tokens_per_expertdesc and slice offrouter.top_kto exclude top-k routed experts from mean/max calc.mlp.tokens_per_expertbuffer.tokens_per_expert.Written by Cursor Bugbot for commit a1d15ea. This will update automatically on new commits. Configure here.