Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated attn_fn #180

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions configs/1B/H100_llama2_edu_no_feat.toml

This file was deleted.

1 change: 0 additions & 1 deletion scripts/export_dcp.py
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,6 @@ def main(config: ExportConfig):
config.type_model,
vocab_size=len(tokenizer),
seq_length=config.data.seq_length,
attn_fn=config.train.attn_fn,
)

# Convert ZeroBand config to HuggingFace config
Expand Down
9 changes: 0 additions & 9 deletions src/zeroband/train.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import os
from typing import Literal
import time
import warnings
import psutil
from pydantic import model_validator
from multiprocessing.process import _children
Expand Down Expand Up @@ -77,14 +76,6 @@ class TrainConfig(BaseConfig):
memory_profiler: MemoryProfilerConfig | None = None

sequence_packing: bool = True
attn_fn: Literal["flash", "sdpa"] | None = None

@model_validator(mode="after")
def validate_attn_fn(self):
if self.attn_fn is not None:
warnings.warn("attn_fn argument is deprecated")

return self


class MonitorConfig(BaseConfig):
Expand Down
Loading