Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix global port in script #19

Merged
merged 2 commits into from
Sep 29, 2024
Merged

fix global port in script #19

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc7ac31
fix global port in script
Jackmin801 Sep 28, 2024
02b22d4
use env vars for ports
Jackmin801 Sep 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions scripts/simulate_multi_node_diloco.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,17 +53,17 @@ trap cleanup SIGINT
mkdir -p logs

export GLOBAL_ADDR=localhost
export GLOBAL_PORT=10000
export GLOBAL_PORT=1234
Jackmin801 marked this conversation as resolved.
Show resolved Hide resolved
export GLOBAL_WORLD_SIZE=$N

for i in $(seq 0 $(($N - 1 )))
do
> logs/log$i
GLOBAL_UNIQUE_ID=$i GLOBAL_RANK=$i CUDA_VISIBLE_DEVICES=$(get_cuda_devices $NUM_GPU $i) uv run torchrun --nproc_per_node=$NUM_GPU --node-rank 0 --rdzv-endpoint localhost:$((10001 + $i)) --nnodes=1 $@ > logs/log$i 2>&1 &
GLOBAL_UNIQUE_ID=$i GLOBAL_RANK=$i CUDA_VISIBLE_DEVICES=$(get_cuda_devices $NUM_GPU $i) uv run torchrun --nproc_per_node=$NUM_GPU --node-rank 0 --rdzv-endpoint localhost:$((10001 + $i)) --nnodes=1 $@ > logs/log$i.log 2>&1 &
Jackmin801 marked this conversation as resolved.
Show resolved Hide resolved
child_pids+=($!)
done

tail -f logs/log0 &
tail -f logs/log0.log &
child_pids+=($!)

wait