[INT-1] On-off ramp global pg #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
23ad8e5#diff-c038af2a144a20667c1465b18904123322a1ba9ebad0d4cf0f1a21b94773839fR269-R270 took me 4 hours to find this ;-; |
samsja
reviewed
Oct 2, 2024
samsja
reviewed
Oct 2, 2024
tests/test_dist/conftest.py
Outdated
| @@ -37,6 +37,17 @@ def get_random_available_port(): | |||
| return s.getsockname()[1] | |||
|
|
|||
|
|
|||
| @pytest.fixture() | |||
There was a problem hiding this comment.
you might have confclit here on the port
There was a problem hiding this comment.
Please use the get_random_available_port_list in test_train.py instead
There was a problem hiding this comment.
yea I couldnt get this to work reliably so I just hardcoded some high port numbers instead. ill just drop this function and put a todo? or u think the hardcoded ports are fine and we just make sure this test is not multiprocessed?
samsja
reviewed
Oct 2, 2024
| import multiprocessing as mp | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("world_size", [2, 8]) |
There was a problem hiding this comment.
Suggested change
| @pytest.mark.parametrize("world_size", [2, 8]) | |
| @pytest.mark.parametrize("world_size", [2, 4]) |
lets keep the test runnable on 4 gpus
There was a problem hiding this comment.
ah the tests run in cpu right now. is that ok?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.