-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INT-1] On-off ramp global pg #29
Conversation
23ad8e5#diff-c038af2a144a20667c1465b18904123322a1ba9ebad0d4cf0f1a21b94773839fR269-R270 took me 4 hours to find this ;-; |
tests/test_dist/conftest.py
Outdated
@@ -37,6 +37,17 @@ def get_random_available_port(): | |||
return s.getsockname()[1] | |||
|
|||
|
|||
@pytest.fixture() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you might have confclit here on the port
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the get_random_available_port_list
in test_train.py
instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea I couldnt get this to work reliably so I just hardcoded some high port numbers instead. ill just drop this function and put a todo? or u think the hardcoded ports are fine and we just make sure this test is not multiprocessed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah sure
import multiprocessing as mp | ||
|
||
|
||
@pytest.mark.parametrize("world_size", [2, 8]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pytest.mark.parametrize("world_size", [2, 8]) | |
@pytest.mark.parametrize("world_size", [2, 4]) |
lets keep the test runnable on 4 gpus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah the tests run in cpu right now. is that ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah makes sense !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LFGTM 🔥
…setup (#29) Summary: Fixes facebookresearch/optimizers#28. Also, it adds `torch` and `torchvision` as requirements and bumps the required Python version to `>=3.10`. **Question:** Is a more recent version than `torch==2.0.0` strictly required for anything? Pull Request resolved: facebookresearch/optimizers#29 Reviewed By: anana10c Differential Revision: D64612120 Pulled By: tsunghsienlee fbshipit-source-id: 9953c51daf58e49afe7ab18c3bd59706484c1823
No description provided.