add activation cktp #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackmin801
reviewed
Oct 2, 2024
| @@ -51,7 +52,7 @@ class TrainConfig(BaseConfig): | |||
| micro_bs: int | |||
| torch_compile: bool = True | |||
| sharding_strategy: str = "SHARD_GRAD_OP" | |||
|
|
|||
| ac_ckpt: bool | int = False | |||
There was a problem hiding this comment.
should this just be int? 0 or -1 if false otherwise the int.
There was a problem hiding this comment.
hmm if it just int it means from the cli you always have to do --ac_ckpt 1 whereas if it an bool we can do --ac_ckpt
tho I agree that it would make the code nice
There was a problem hiding this comment.
up to u then haha. fine either way. I think u actually can get away with not doing the isinstance bool check and just directly pass along True since True is treated as 1 :p
but dont do it. its confusing
There was a problem hiding this comment.
yeah I thought about doing it but does not sounds nice haha
Jackmin801
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.