Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

models/MontagueDayanSejnowski: Use versioned seaborn style #2808

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

jvesely
Copy link
Collaborator

@jvesely jvesely commented Sep 29, 2023

Plain names are deprecated in matplotlib and removed in matplotlib==3.8.0.
The versioned name with underscore was introduced in matplotlib==3.7.0, 6608eedfc6f33f723f1e13c6025a5b918c7c9f6d
("Re-rename builtin seaborn styles to not include a dot.")

@jvesely jvesely requested review from kmantel and jdcpni September 29, 2023 13:24
Plain names are deprecated in matplotlib.
The versioned name with underscore was introduced in matplotlib==3.7.0,
6608eedfc6f33f723f1e13c6025a5b918c7c9f6d
	("Re-rename builtin seaborn styles to not include a dot.")

Signed-off-by: Jan Vesely <[email protected]>
Copy link

github-actions bot commented Jan 7, 2025

This PR causes the following changes to the html docs (ubuntu-latest-3.11):

diff -r docs-base/TransferFunctions.html docs-head/TransferFunctions.html
2562c2562
< <p><a class="reference internal" href="TimerFunctions.html#psyneulink.core.components.functions.nonstateful.timerfunctions.AsymptoticTimer.bounds" title="psyneulink.core.components.functions.nonstateful.timerfunctions.AsymptoticTimer.bounds"><code class="xref any py py-attr docutils literal notranslate"><span class="pre">bounds</span></code></a> – specifies the lower and upper limits of the result;  if there are none, the attribute is set to
---
> <p><a class="reference internal" href="OptimizationFunctions.html#psyneulink.core.components.functions.optimizationfunctions.GradientOptimization.bounds" title="psyneulink.core.components.functions.optimizationfunctions.GradientOptimization.bounds"><code class="xref any py py-attr docutils literal notranslate"><span class="pre">bounds</span></code></a> – specifies the lower and upper limits of the result;  if there are none, the attribute is set to
diff -r docs-base/_downloads/a4d0d527489dd865a0d84206f08d9c31/MontagueDayanSejnowski96.py docs-head/_downloads/a4d0d527489dd865a0d84206f08d9c31/MontagueDayanSejnowski96.py
116c116
<         with plt.style.context('seaborn'):
---
>         with plt.style.context('seaborn-v0_8'):
179c179
<         with plt.style.context('seaborn'):
---
>         with plt.style.context('seaborn-v0_8'):
243c243
<         with plt.style.context('seaborn'):
---
>         with plt.style.context('seaborn-v0_8'):

...

See CI logs for the full diff.

@jvesely jvesely merged commit 3b30abb into PrincetonUniversity:devel Jan 7, 2025
33 checks passed
@jvesely jvesely deleted the mpl branch January 7, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants