Skip to content

(old) Bugfix in Igeom=1 Lcons=3 and output of stability variables #215

Closed
ErolBa wants to merge 37 commits intomasterfrom
Igeom1_pflux_fix
Closed

(old) Bugfix in Igeom=1 Lcons=3 and output of stability variables #215
ErolBa wants to merge 37 commits intomasterfrom
Igeom1_pflux_fix

Conversation

@ErolBa
Copy link
Copy Markdown
Collaborator

@ErolBa ErolBa commented Dec 4, 2024

This pull request involves the following modifications:

  1. Primary modification: fixes a bug when running with Igeometry=1 and Lconstraint=3, adds the total pflux as a conserved quantity (otherwise the Beltrami solver is missing a conserved quantity).
  2. Outputs .hessian matrix for stability analysis
  3. Calculates and outputs plasma beta
  4. Outputs_ quantities related to stability in the .h5 file (eigvals, eigvecs, and the hessian matrix)

@ErolBa ErolBa marked this pull request as draft December 4, 2024 14:54
@ErolBa ErolBa marked this pull request as ready for review December 4, 2024 18:45
@ErolBa
Copy link
Copy Markdown
Collaborator Author

ErolBa commented Dec 4, 2024

The tests pass (if trivially Lconstraint and LBeltrami are not checked, we can change those). However, the test for slab (G=1) seems lacking, and there should be a test involving different Lconstraints. Particularly, with Lcons=3 where the bug was present.

@ErolBa ErolBa closed this Dec 12, 2024
@ErolBa ErolBa changed the title Bugfix in Igeom=1 Lcons=3 and output of stability variables (old) Bugfix in Igeom=1 Lcons=3 and output of stability variables Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant