Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(old) Bugfix in Igeom=1 Lcons=3 and output of stability variables #215

Closed
wants to merge 37 commits into from
Closed

(old) Bugfix in Igeom=1 Lcons=3 and output of stability variables #215

wants to merge 37 commits into from
+186 −18

Conversation

ErolBa
Copy link
Collaborator

@ErolBa ErolBa commented Dec 4, 2024

This pull request involves the following modifications:

  1. Primary modification: fixes a bug when running with Igeometry=1 and Lconstraint=3, adds the total pflux as a conserved quantity (otherwise the Beltrami solver is missing a conserved quantity).
  2. Outputs .hessian matrix for stability analysis
  3. Calculates and outputs plasma beta
  4. Outputs_ quantities related to stability in the .h5 file (eigvals, eigvecs, and the hessian matrix)

ErolBa and others added 30 commits December 1, 2022 17:31
@ErolBa
Updates to writing Ipdt to .end file; and constratining total pflux t…
ae907fb 
…o a constant for slab geom. and Lconstraint 3
@ErolBa
small fix
9cc0112
@ErolBa
minor changes
c341344
@ErolBa
change to requirements
044cc7f
@ErolBa
Formatting changes. So the wrapper compiles for this branch
0d7ce7c
@ErolBa
hessian file should be visible
9d56d7b
@ErolBa
Fixed bug in dforce
e0cb4f4
@ErolBa
Do not need the .DF file
fcc6bdb
@ErolBa
updates to beta
93827fc
@ErolBa
allow more volumes
db4e7b0
@ErolBa
change
91dc66a
@ErolBa
out stability metrics to h5 file
3c08d8f
@ErolBa
change
7bc2c20
@ErolBa
change2
42a4748
@ErolBa
change2
5c2e669
@ErolBa
change3
f45ca55
@ErolBa
Mostly formatting
f3b9b82
@ErolBa
Formatting ...
e1e15ae
better printing of stability items
8d5ab5d
@ErolBa
Catching up to main
9f76ee1
@ErolBa
utilities
b8420c7
@ErolBa
merge with master...
d4d9e95
@ErolBa
catchin up 2...
6fd54fd
@ErolBa
print .hessian
0611dd0
@ErolBa
pulling changes from master
2f30b52
@ErolBa
keep up w master 2
7dddaa9
@ErolBa
keep up w master 3
d7c944c
@ErolBa
keep up w master 4
1ad8de2
@ErolBa
keep up w master 5
58e4e0d
@ErolBa
keep up w master 5b
5919a62
@ErolBa ErolBa marked this pull request as draft December 4, 2024 14:54
@ErolBa ErolBa marked this pull request as ready for review December 4, 2024 18:45
@ErolBa
Copy link
Collaborator Author

ErolBa commented Dec 4, 2024

The tests pass (if trivially Lconstraint and LBeltrami are not checked, we can change those). However, the test for slab (G=1) seems lacking, and there should be a test involving different Lconstraints. Particularly, with Lcons=3 where the bug was present.

@ErolBa ErolBa closed this Dec 12, 2024
@ErolBa ErolBa changed the title Bugfix in Igeom=1 Lcons=3 and output of stability variables (old) Bugfix in Igeom=1 Lcons=3 and output of stability variables Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ErolBa