Merged
Conversation
jonathanschilling
approved these changes
Dec 7, 2024
Collaborator
jonathanschilling
left a comment
jonathanschilling
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for the fixes!
Collaborator
|
Waiting a bit to merge as I am in the process of recovering the SPEC-devel PYPI account to fix the upload to PYPI workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nonechecks should be done with is None in python, instead of== Noneto avoid issues with equality overloads.Passing an RGB color (np.array) to to the plotting functions threw at the None comparison, because numpy arrays need
.any()or.all()for comparisons. I also refactored other instances of the same bug across the codebase.plot_poincare now also ignores points that were unsuccessfully integrated instead of plotting them at [0,0]