-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BYOC Support for BlackParrot RV64GC #158
Open
dpetrisko
wants to merge
21
commits into
PrincetonUniversity:openpiton-dev
Choose a base branch
from
dpetrisko:bp-rc2
base: openpiton-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jonathan Balkind <[email protected]>
Jbalkind
reviewed
Oct 9, 2024
Jbalkind
reviewed
Oct 9, 2024
Jbalkind
reviewed
Oct 9, 2024
@@ -97,10 +104,17 @@ if {[info exists ::env(PITON_ARIANE)]} { | |||
append ALL_DEFAULT_VERILOG_MACROS " PITON_ARIANE PITON_RV64_PLATFORM PITON_RV64_DEBUGUNIT PITON_RV64_CLINT PITON_RV64_PLIC WT_DCACHE" | |||
} | |||
|
|||
if {[info exists ::env(PITON_BLACKPARROT)]} { | |||
append ALL_DEFAULT_VERILOG_MACROS " PITON_BLACKPARROT PITON_RV64_PLATFORM PITON_RV64_DEBUGUNIT PITON_RV64_CLINT PITON_RV64_PLIC" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we probably don't want PITON_RV64_DEBUGUNIT here right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah probably. We do have debug unit support, but I think it's not hooked up right now
Jbalkind
reviewed
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #130, copying description here:
This PR adds support for BlackParrot simulation to OpenPiton via the BYOC framework. OpenPiton+BlackParrot on FPGA is currently beta.
There is a necessary fix to the L2 cache, which replicates the data of subword requests, as required by P-Mesh. This should be compatible with existing implementations which mux the word from the correct byte offset. It just allows implementations to be lazy and use whichever is more convenient. I can separate this out to a second PR if helpful.