Openpiton Support for NetFPGA-SUME board #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jbalkind
reviewed
Jun 7, 2020
There was a problem hiding this comment.
This is awesome! Could you say a bit more about what you can and can't do on SUME with the support you added?
I've added a set of comments from a quick review that would be good to be addressed. We may want to try to test this out on our end before merging. Not sure yet but will get back to you on that.
Thanks a ton!
piton/tools/src/proto/fpga_lib.py
Outdated
| @@ -263,11 +274,9 @@ def getTestList(fname, flog, ustr_files=False): | |||
| def runMidas(tname, uart_div_latch, flog, midas_args=None, coreType="sparc", precompiled=False, x_tiles=1, y_tiles=1): | |||
| cmd = "" | |||
| if midas_args is None: | |||
| cmd = "sims -sys=manycore -novcs_build -midas_only \ | |||
| -midas_args='-DUART_DIV_LATCH=0x%x -DFPGA_HW -DCIOP -DNO_SLAN_INIT_SPC' %s" % (uart_div_latch, tname) | |||
| cmd = "/var/services/homes/mabbasidinan/work/hw_memoization/openpiton/piton/tools/bin/sims -sys=manycore -novcs_build -midas_only -midas_args='-DUART_DIV_LATCH=0x%x -DFPGA_HW -DCIOP -DNO_SLAN_INIT_SPC' %s" % (uart_div_latch, tname) | |||
There was a problem hiding this comment.
No need for this absolute path here
piton/tools/src/proto/fpga_lib.py
Outdated
| else: | ||
| cmd = "sims -sys=manycore -novcs_build -midas_only \ | ||
| -midas_args='-DUART_DIV_LATCH=0x%x -DFPGA_HW -DCIOP -DNO_SLAN_INIT_SPC %s' %s" % \ | ||
| cmd = "/var/services/homes/mabbasidinan/work/hw_memoization/openpiton/piton/tools/bin/sims -sys=manycore -novcs_build -midas_only -midas_args='-DUART_DIV_LATCH=0x%x -DFPGA_HW -DCIOP -DNO_SLAN_INIT_SPC %s' %s" % \ |
piton/tools/src/proto/fpga_lib.py
Outdated
| @@ -283,6 +292,7 @@ def runMidas(tname, uart_div_latch, flog, midas_args=None, coreType="sparc", pre | |||
| # used to run precompiled riscv tests | |||
| cmd += " -precompiled" | |||
|
|
|||
| print cmd | |||
There was a problem hiding this comment.
Can we remove this print?
| set_property "target_constrs_file" "$constraints_file" $fileset_obj | ||
|
|
||
| #set_property "target_constrs_file" "$constraints_file" $fileset_obj | ||
| set_property "target_constrs_file" "$debug_constraints_file" $fileset_obj |
| @@ -177,7 +177,11 @@ set fileset_obj [get_filesets constrs_1] | |||
|
|
|||
| # Add/Import constrs file and set constrs file properties | |||
| set constraints_file "${BOARD_DIR}/constraints.xdc" | |||
| set board_constraints_file "${BOARD_DIR}/SUME_Master.xdc" | |||
There was a problem hiding this comment.
I don't know about these changes in gen_project.tcl. Can we get them to be SUME-only somehow?
piton/design/rtl/system.v
Outdated
| @@ -381,7 +407,10 @@ module system( | |||
| input btnc, | |||
| `endif | |||
|
|
|||
| `ifdef VCU118_BOARD | |||
| `ifdef SUME_BOARD | |||
| //input reset, | |||
There was a problem hiding this comment.
Is this block necessary if it's commented out?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains the information of NetFPGA-SUME board and required changes to run Openpiton on this board.
Known issue:
1- Currently, there is no support for the network interface in this pull request. To run the Linux on NetFPGA-SUME, ariane_sdk should be built without the Xilinx NIC driver.
2- Instead of the reset button there is Virtual IO module that used for resetting the system.
3- The sd_cd signal should be manually asserted and de-asserted manually through VIO to boot the Linux. VIO facilitates use of FPGA words that users do not have direct access to and connect to over the network.
Support for NetFPGA-SUME This work has been done as a part of a research project in the COMPAS Lab, StonyBrook University. (https://compas.cs.stonybrook.edu/)