Add Advancements Data #583

Lianecx · 2022-06-21T15:03:03Z

I've created an advancement data file for another project and noticed that this repo doesnt have data for advancements yet.

Eejit and I adjusted it to fit the style of other data files and we added lots of new informational properties.

u9g · 2022-06-21T16:21:08Z

How did you create it?

Lianecx · 2022-06-21T18:34:17Z

How did you create it?

At first, I just copied over each of the properties manually, but i realised I could've just used the advancements table of the fandom wiki and convert it to json using a tool.
For the criteria, Ill have to do them manually as they are not listed anywhere on the wiki.

Lianecx · 2022-06-21T18:34:59Z

Is there anything wrong with it? Because the CI test did fail 🤔

Eejit43 · 2022-06-21T18:37:07Z

Is there anything wrong with it? Because the CI test did fail 🤔

Only that it isn't included in dataPaths.json

Lianecx · 2022-06-21T18:38:03Z

Ah I see, sorry about that

Lianecx · 2022-06-21T18:39:37Z

I also need to create a schema right?

Lianecx · 2022-06-21T18:45:28Z

How did you create it?

At first, I just copied over each of the properties manually, but i realised I could've just used the advancements table of the fandom wiki and convert it to json using a tool. For the criteria, Ill have to do them manually as they are not listed anywhere on the wiki.

This could probably all be automated using the minecraft language file.

Lianecx · 2022-06-21T18:46:57Z

How did you create it?

At first, I just copied over each of the properties manually, but i realised I could've just used the advancements table of the fandom wiki and convert it to json using a tool. For the criteria, Ill have to do them manually as they are not listed anywhere on the wiki.

This could probably all be automated using the minecraft language file as it contains all the advancement descriptions, displaynames and IDs (resource locations).

Eejit43 · 2022-06-21T19:07:00Z

I'll work on making a tool to generate this automatically

Lianecx · 2022-06-21T19:07:52Z

I'll work on making a tool to generate this automatically

If you want, I can do it myself :D

Lianecx · 2022-06-21T19:08:19Z

Do you know what wrong in the bedrock CI test?

Eejit43 · 2022-06-21T19:10:01Z

Unsure about the CI test, but already working on that tool. I'll let you know when I make progress!

Lianecx · 2022-06-21T19:10:48Z

Unsure about the CI test, but already working on that tool. I'll let you know when I make progress!

Okay, sure then!

Eejit43 · 2022-06-21T19:30:46Z

Alright I've made a a tool to generate it. I'll create a separate PR and add that data there!

Lianecx · 2022-06-21T19:31:52Z

G

Alright I've made a a tool to generate it. I'll create a separate PR and add that data there!

Awesome!

Eejit43 · 2022-06-21T19:32:57Z

See #584! Thanks for making this, that was a very good idea!

u9g · 2022-06-21T19:50:28Z

Why is this data helpful? Wouldn’t it be more helpful for you to just access the raw advancement json from a datapack?

Lianecx · 2022-06-21T20:07:51Z

Why is this data helpful? Wouldn’t it be more helpful for you to just access the raw advancement json from a datapack?

It's great to have every minecraft data combined in a single package. I'm not exactly sure about the raw advancement json youre talking about. Isnt every advancement stored in seperate files which makes everything very inconvenient?
Also, the displayName and description are in the language file only and not included in the raw json.

Lianecx · 2022-06-22T10:17:12Z

@Eejit43 Let me know if you want me to change the format to anything specific.

…for wearing (`distract_piglin`, `distract_piglin_directly`)

update/add advancements

Lianecx · 2022-06-25T07:24:24Z

Should be ready to merge now

Lianecx · 2022-07-06T07:12:16Z

Is there still anything missing here?

Eejit43 · 2022-07-06T13:53:07Z

Is there still anything missing here?

nope we just need to wait for it to be reviewed.

Lianecx · 2022-07-06T14:15:16Z

Is there still anything missing here?

nope we just need to wait for it to be reviewed.

How long does that take usually?

Eejit43 · 2022-07-06T14:17:17Z

Is there still anything missing here?

nope we just need to wait for it to be reviewed.

How long does that take usually?

who knows; whenever they get around to it

Eejit43 · 2022-07-12T23:59:38Z

@Lianecx also you should update the title of this PR

rom1504 · 2022-07-13T16:28:46Z

doc/add-data-new-version.md

 | language.json | Yes | Use [minecraft-jar-extractor][10] |
 | particles.json | Yes | Use [Burger][1], then use [burger-extractor][2] |
 | blockLoot.json | Yes | Use [minecraft-jar-extractor][10] |
 | entityLoot.json | Yes | Use [minecraft-jar-extractor][10] |
 | mapIcons.json | No | Icons can be found in the Minecraft jar file where they are added as a single sprite. The file location is `/assets/minecraft/textures/map/map_icons.png`. Alternatively you might be able to look up the icons from the following page on the [Minecraft wiki][15] or from [wiki.vg][16]. | [minecraft-data pr mapIcons][14] |
+| advancements.json | Yes | To be added |


Can you indicate here the method to add this file for new versions?

Eejit43 · 2022-07-13T16:37:20Z

Created a PR to update this PR with that change (see here)

Lianecx · 2022-07-13T16:45:52Z

Created a PR to update this PR with that change (see here)

~~Can you make a pr in my fork to add this~~
Sorry i oversaw that

add advancement extractor link

rom1504 · 2022-08-07T14:44:21Z

still thinking whether this should be here or not

@u9g was thinking not because it doesn't come from the main extractor

let's think a bit more

Eejit43 · 2022-10-17T14:08:26Z

still thinking whether this should be here or not

@u9g was thinking not because it doesn't come from the main extractor

let's think a bit more

Any updates on this? It could be adapted into the main extractor

rom1504 · 2023-03-04T18:11:09Z

not too eager to add this huge piece of data unless someone still finds it useful

is anyone using this ?

Lianecx · 2023-03-04T18:31:51Z

I would 100% use this

rom1504 · 2023-07-29T09:20:41Z

ok @Lianecx can you open a corresponding PR in node-minecraft-data and then we merge this ?

Lianecx · 2023-07-29T09:31:21Z

Okay, Ill do that 👍
Feel free to remind me if i forget

rom1504 · 2023-12-17T22:30:39Z

@Lianecx gentle reminder

Add advancements.json

92ee9a0

Add advancements to dataPaths.json

ebd0afc

Add advancements_schema.json

f92db8b

Eejit43 mentioned this pull request Jun 21, 2022

Add advancements data #584

Closed

Add new category field to advancements

a1f95f7

update 1.19 data and schema

373eb5b

Eejit43 added 5 commits June 22, 2022 11:14

add advancements to README

26cd81c

Merge branch 'PrismarineJS:master' into master

d6b54ca

add requirements

e7a44b7

Merge branch 'master' of https://github.com/Eejit43/minecraft-data

0697038

add advancements triggers

0a22991

Eejit43 and others added 8 commits June 23, 2022 18:21

revert endcity --> end_city rename

92bb98d

update add-data-new-version.md

147d659

remove minecraft namespace prefix

6c55ee2

block --> blocks (account for multiple), add support for options …

08485b7

…for wearing (`distract_piglin`, `distract_piglin_directly`)

fix distance in schema

6704c22

update schema

ca5e81e

ensure entities from parent is always an array in older versions

598eba2

Merge pull request #2 from Eejit43/master

60c6437

update/add advancements

Lianecx changed the title ~~Add advancements data 1.19~~ Add Advancements Data Jul 13, 2022

rom1504 reviewed Jul 13, 2022

View reviewed changes

add advancement extractor link

2396288

Merge pull request #3 from Eejit43/master

a9ce79a

add advancement extractor link

rom1504 added this to Needs triage in PR Triage Aug 7, 2022

rom1504 moved this from Needs triage to Waiting for user input in PR Triage Aug 7, 2022

rom1504 moved this from Waiting for user input to Almost too old in PR Triage Mar 4, 2023

Add Advancements Data #583

Are you sure you want to change the base?

Add Advancements Data #583

Conversation

Lianecx commented Jun 21, 2022 • edited Loading

u9g commented Jun 21, 2022

Lianecx commented Jun 21, 2022

Lianecx commented Jun 21, 2022

Eejit43 commented Jun 21, 2022

Lianecx commented Jun 21, 2022

Lianecx commented Jun 21, 2022

Lianecx commented Jun 21, 2022

Lianecx commented Jun 21, 2022 • edited Loading

Eejit43 commented Jun 21, 2022

Lianecx commented Jun 21, 2022

Lianecx commented Jun 21, 2022

Eejit43 commented Jun 21, 2022 • edited Loading

Lianecx commented Jun 21, 2022

Eejit43 commented Jun 21, 2022

Lianecx commented Jun 21, 2022

Eejit43 commented Jun 21, 2022

u9g commented Jun 21, 2022 • edited Loading

Lianecx commented Jun 21, 2022 • edited Loading

Lianecx commented Jun 22, 2022

Lianecx commented Jun 25, 2022

Lianecx commented Jul 6, 2022

Eejit43 commented Jul 6, 2022

Lianecx commented Jul 6, 2022

Eejit43 commented Jul 6, 2022

Eejit43 commented Jul 12, 2022

rom1504 Jul 13, 2022

Choose a reason for hiding this comment

Lianecx Jul 13, 2022

Choose a reason for hiding this comment

Eejit43 commented Jul 13, 2022

Lianecx commented Jul 13, 2022 • edited Loading

rom1504 commented Aug 7, 2022

Eejit43 commented Oct 17, 2022

rom1504 commented Mar 4, 2023

Lianecx commented Mar 4, 2023

rom1504 commented Jul 29, 2023

Lianecx commented Jul 29, 2023

rom1504 commented Dec 17, 2023

Lianecx commented Jun 21, 2022 •

edited

Loading

Lianecx commented Jun 21, 2022 •

edited

Loading

Eejit43 commented Jun 21, 2022 •

edited

Loading

u9g commented Jun 21, 2022 •

edited

Loading

Lianecx commented Jun 21, 2022 •

edited

Loading

Lianecx commented Jul 13, 2022 •

edited

Loading