Make sure we pass a string to a storagebuilder (#2645)

* Make sure we pass a string to a storagebuilder * Add test * Fix lint --------- Co-authored-by: Romain Beaumont <[email protected]>
PrismarineJS · Jul 29, 2023 · fc95843 · fc95843
1 parent b336d22
commit fc95843
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/lib/plugins/blocks.js b/lib/plugins/blocks.js
@@ -470,9 +470,11 @@ function inject (bot, { version, storageBuilder, hideErrors }) {
     if (bot.supportFeature('dimensionIsAnInt')) {
       return dimensionNames[dimension]
     } else if (bot.supportFeature('dimensionIsAString') || bot.supportFeature('dimensionIsAWorld')) {
-      return dimension
+      return worldName
     }
   }
+  // only exposed for testing
+  bot._getDimensionName = () => worldName
 
   async function switchWorld () {
     if (bot.world) {
@@ -503,9 +505,10 @@ function inject (bot, { version, storageBuilder, hideErrors }) {
   bot._client.on('login', (packet) => {
     if (bot.supportFeature('dimensionIsAnInt')) {
       dimension = packet.dimension
+      worldName = dimensionToFolderName(dimension)
     } else {
       dimension = packet.dimension
-      worldName = packet.worldName
+      worldName = /^minecraft:.+/.test(packet.worldName) ? packet.worldName : `minecraft:${packet.worldName}`
     }
     switchWorld()
   })

diff --git a/test/externalTests/dimensionName.js b/test/externalTests/dimensionName.js
@@ -0,0 +1,5 @@
+const assert = require('assert')
+
+module.exports = () => async (bot) => {
+  assert.strictEqual(bot._getDimensionName(), 'minecraft:overworld')
+}