feat: Add optimistic update for block placement #3391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code changes in `place_block.js` introduce an optimistic update feature for block placement. This feature sets the default state of the block being placed based on the held item. It retrieves the default state from the `minecraft-data` module and updates the block state at the destination accordingly. This optimistic update improves the responsiveness of block placement. Note: This suggested commit message follows the convention of using a prefix to indicate the type of change (`feat` for a new feature).
extremeheat
requested changes
Jun 7, 2024
Comment on lines
+12
to
+17
| const heldItem = bot.heldItem | ||
| const mcData = require('minecraft-data')(bot.version) | ||
| const defaultState = mcData.blocksByName[heldItem?.name]?.defaultState | ||
| if (defaultState) { | ||
| bot.world.setBlockStateId(dest, defaultState) | ||
| } |
There was a problem hiding this comment.
- This should be using the registry
- This is not a correct way to deduce correct block state from an item
- If world state is mutated then you must ensure that the data is fully in sync with the server (how does this handle the case where the server rejects?)
There was a problem hiding this comment.
I believe I already answered 3rd question in the description. If the server rejects a block update would be emitted (even if it's air) as this is what the native client also does.
Can you elaborate on the 2nd question?
I don't know how to find things in the native client source I could check it by launching the client. This was always the behaviour of minecraft client. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what native client does. It is important if the ping is low and after placement, calculates physics correctly. If the placement is not allowed the block is still updated to air by the server.
Maybe it's worth adding it as a setting to not break existing behaviors, but I don't see a reason why it shouldn't be enabled by default .