We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional fields are currently ignored (see https://github.com/PrismarineJS/node-minecraft-protocol/blob/master/src/protocol.js#L1503) Missing fields are currenlty passed as undefined.
It would be better to emit some error. Related to PrismarineJS/mineflayer#269
The text was updated successfully, but these errors were encountered:
same as #127
Sorry, something went wrong.
Missing is easy to do. Additional might have some non-acceptable overhead though.
Missing is mostly about throwing an error if value[typeArg.name] is undefined there https://github.com/roblabla/ProtoDef/blob/master/src/datatypes/structures.js#L134
value[typeArg.name]
I'm not sure if checking for additional fields has any use. And yeah, it would mean going through the value object keys, which can be a little costly.
moved tracking to ProtoDef-io/node-protodef#61
No branches or pull requests
Additional fields are currently ignored (see https://github.com/PrismarineJS/node-minecraft-protocol/blob/master/src/protocol.js#L1503)
Missing fields are currenlty passed as undefined.
It would be better to emit some error.
Related to PrismarineJS/mineflayer#269
The text was updated successfully, but these errors were encountered: