Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit an error for missing or additional fields in containers #61

Open
rom1504 opened this issue Mar 1, 2016 · 3 comments
Open

Emit an error for missing or additional fields in containers #61

rom1504 opened this issue Mar 1, 2016 · 3 comments

Comments

@rom1504
Copy link
Member

rom1504 commented Mar 1, 2016

PrismarineJS/node-minecraft-protocol#156
@rom1504 rom1504 mentioned this issue Mar 1, 2016
Closed
@roblabla
Copy link
Collaborator

roblabla commented Mar 1, 2016

This would incur a very significant overhead. I think this should only happen :

  1. in a "debug mode"
  2. when an option is set in the typeArgs
  3. never, delegate that functionality to a user type.

@Saiv46
Copy link
Contributor

Saiv46 commented Jun 13, 2020

IMO, ProtoDef responsible only for (de-)serializing buffers with pre-defined protocol, it assumes that input is safe and trusted.

@rom1504
Copy link
Member Author

rom1504 commented Jun 13, 2020 •
edited
Loading

It would definitely help users to do something here, of course without having a performance penalty.
Issue is still valid

@rom1504 rom1504 closed this as completed Jun 13, 2020
@rom1504 rom1504 reopened this Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@roblabla @rom1504 @Saiv46