Merge pull request #248 from PrisonTeam/bleeding_branch_v3.3.0-alpha.14

Bleeding branch v3.3.0 alpha.14

docs/changelog_v3.2.x.md

@@ -4,6 +4,7 @@
 
 ## Build logs
  - **[v3.3.x - Current](changelog_v3.3.x.md)**
+ - [v3.2.0 through v3.3.0-alpha.14](prison_changelogs.md)
  - [v3.2.0 - 2019-12-03](prison_changelog_v3.2.0.md)  
 [v3.2.1 - 2020-09-27](prison_changelog_v3.2.1.md)  
 [v3.2.2 - 2020-11-21](prison_changelog_v3.2.2.md)  

docs/changelog_v3.3.x.md

@@ -4,15 +4,130 @@
 
 ## Build logs
  - **[v3.3.0-alpha - Current](changelog_v3.3.x.md)**
- - [v3.2.0 through v3.2.10](prison_changelogs.md)
+ - [v3.2.0 through v3.3.0-alpha.14](prison_changelogs.md)
 
 
 These build logs represent the work that has been going on within prison. 
 
 
+# 3.3.0-alpha.14 2023-01-23
+
+
+**Prison v3.3.0-alpha.14 2023-01-23**
+
+
+The following are significant changes that are included in the alpha.14 release since the alpha.13 release was posted.
+
+* Support for RevEnchants
+
+
+* Added more flexibility in supporting Prison Event Listener priorities for block break events so prison is better suited to support more enchantment plugins under more conditions. Added ACCESS, ACCESSBLOCKBREAKS, and ACCESSMONITOR to provide far more flexibility when prison is NOT managing the block breakage.
+
+
+* General improvements in how Auto Features manages the event listeners for all of the block break events. Includes some bug fixes and performance improvements too.
+
+
+* Preparing to support ItemsAdder... will be available in next alpha release.*
+
+
+* Prison Placeholders: Added a few more, fixed a few bugs, and improved documentation so its easier to understand how to use them. Added more features to the command `/prison placeholders stats`.  The stats command can actually be used to troubleshoot issues with third-party plugins trying to use prison placeholders.
+
+
+* Top-n reports and placeholders: bug fixes and added a few more features.
+
+
+* Mine commands: refactor and improvements to some of the general mine commands.
+
+
+* Prison Placeholders: general bug fixes and performance improvements with the placeholder cache.
+
+
+* Prison's bstats: Expanded the reports that are being included.
+
+
+* Prison Command Handler: ability to lockout players from commands and tab-completes based upon perms.
+
+
+* Mines GUI Bug fixes: fixed a few issues.
+
+
+* Issue with vault not working with essentials: Not able to access player's balances through vault and provided alternative paths to resolve this issue.
+
+
+* Prison support new feature: tracking command usage along with average run times: `/prison support cmdStats`. 
+
+
+* Updates to a number of libraries that prison uses: 
+placeholderApi: v2.10.9 to v2.11.2
+XSeries: v9.0.0 to v9.2.0
+item-nbt-api: v2.10.0 to v2.11.1
+
+
+* Removal of support for MVDW placeholders since it's not able to support some of prison's advanced features, plus it's 100% redundant since PlaceholderAPI works in conjunction with it. No loss of service since PAPI is a better solution and works with MVDW.
+
+
+* Added a Prison Backup feature that can make a backup of all the settings within prison's plugin directory (small zip file backups).  It is setup to make a backup whenever it detects a change in the prison versions.  In the future, it could be automated to make snapshots of all settings and player status so there can be abilities to "rollback" to a prior instance.
+
+
+* Added new translations: Finnish, Chinese, 
+
+
+* Enhanced the player GUIs for mines and ranks to use NBT to control the options to simplify how the options work. Eliminated a lot of old code and added more flexibility.
+
+
+* Enable the sellall command to be ran from the console or from a prison command.
+
+
+* Enhanced the debug logging detail related to the auto features. Provides better logging for troubleshooting.
+
+
+* Using a static global setting for decimal formatting to better control how numeric formatting works with various language settings.
+
+
+* Able to now control suffocation in the mines, so you can now allow players to die if they logged out within a mine and they log back buried in rock.
+
+
+* Able to control mine reset teleportation controls.
+
+
+* Added direct support for translating placeholders through the Prison API so its easier to use externally through another plugin.
+
+
+* Now able to set a prestige rank tag to use for players that do not have a prestige rank. This allows for better customization for chat prefixes.
+
+
+* Fixed a bug when trying to move a mine from one world to another world.  There was a conflict with an internal value not being cleared/reset.
+
+
+* Fixed a Prison Mine Bomb bug that was making them incompatible with bukkit 1.8.8.
+
+
+* Fixed a bug with how a vector's length was being calculated. Not sure how frequently this would have been used.
+
+
+* Refactoring Prison Backpacks. Getting ready to hook them up to a new internal backpack cache to improve performance.  Not yet completed.
+
+
+* Fixed bug with /rankupmax and rewrote prestiges to better align it with the ranks module instead of relying upon the GUI code to manage it.
+
+
+* Enhanced many mine and rank commands to apply changes to all ranks or all mines with one command to make it easier to customize prison.
+
+
+* New feature setting (optional): Forced rankup as soon as the player earns enough money through sellall.
+
+
+* New feature setting (optional): Forced sellall before performing a prestige.
+
+
+* New feature setting (optional): Prevent access to prior mines when ranking up. This foces the player to only have access to mines that are linked to the current rank.  This feature allows the use of Mine and TP access by rank instead of having to setup complex settings with perms through a permission plugin.
+
+
+
+---------------------------
+
 
 
-# 3.3.0-alpha.13 2022-08-25
 
 
 **3.3.0-alpha.13 2022-08-25**

docs/knownissues_v3.3.x.md

@@ -8,30 +8,56 @@
 # TODO Items for v3.3.0-alpha.13
 
 
-- In the GUI menu, the config setting: Enchantment_effect_current_rank is off by 1.  If D rank it shows E being unlocked. - CITYJD
+- On the new cmdStats details, add nano run times for commands so we can include avg run times.
 
 
-- Add `*all*` to `/mines set notification` - CITYJD
+- Add a command usage count to commands.  Then a simple report to list what commands were used, along with total command count of active commands.
 
 
-- Auto-Forced-Rankups and prestiges when the player has enough money.  Kikiisyourfriend
- - a new autoFeatures entry
+- Expand upon the config.yml command lockout so that if the player does not have access to a command, then suppress that command from all players, including command listings.  Not all commands will be able to reject access due to the nature of the commands (all access to everyone) and/or the use of alt-perms (programmatic evaluation to the commands).  - Josh-65
+
+
+- File save to new format - OmarG
+  - pre-req for turning off TP
+  - pre-req for custom mine shapes
+
+
+- Ability to turn of TP on mine resets.  OmarG
+  - Maybe have a special value for spawn to indicate it should TP?
+  - Could still have a spawn point, but just not tp during resets.
+
+
+- custom mine shapes - Chain and Fiba1 and OmarG
+ - Have a new command to edit and save the mine's shapes
+ - edit would spawn red/yellow wool - remove blocks - save would only save the wool blocks.
 
-- Enable Access to prior mines - kikiisyourfriend
- - disable to prevent going back to prior rank mines.
 
+- fix gui ranks to remove italics from the rank names.  This may be the gui ranks and/or the gui prestiges.  - Bryton
+  Cannot reproduce - No italics are being added by prison.
 
-- DONE: prison_rank__linked_mines_rankname prison_r_lm_rankname provide a placeholder for the mine's tags.  B0mer
 
+- DONE: Gui prestiges - option to remove the gui prestige button.  Not sure if any of the options in the config.sys really supports that.  - Bryton
+
+
+
+- Prestige - needs improvements
+    DONE: rewrote the prestige handling to exist in the ranks module. Everything is handled properly now. The GUI is passed the correct lore so no rankup logic is in the gui anymore. Prechecks are now enabled too.
+  - DONE: Confirmation does not perform any prechecks to confirm if the player can even prestige
+  - DONE: Confirmation does not reflect prestige settins. It always shows that rank and balance will be reset, even if that is disabled.
+  - DONE: It's not clear how to confirm via chat
+
+
+- when testing the block breakage with the SHIFT-click with the mine wand, I also saw that it processed the same block twice.  The first time looked as if the drop was being canceled, then the second time the event was being canceled.  Or vice-a-versa.  I don't remember setting it up both ways.
 
-- DONE: Mines tp: option to list all available mines per rank? Thaysa
 
 
 - bStats:
  - DONE: Remove Plugins & Prison Ladders
  - DONE: Add: modules, Economy (integrations), Perms (integrations), Placeholder (intg)
  - DONE: Add: Language
- - 
+ - Eliminate zero counts (don't report)
+ - validate that plugins listed in other reports are being removed from plugins a-z.
+
 
 
 - `/ranks player` is not including all of the info for rank multipliers like it should have.
@@ -55,7 +81,7 @@
 
 
 
-- DONE: Option to skip applying the rank cost multiplier to a specific ladder.
+
 
 
 - For v3.3.0 release:
@@ -66,7 +92,7 @@
   - ranks and ladders
     - auto prestiges (unlimited) based upon formulas
     - new file formats - json ORM?
-  - DONE usind topn: archiving old players
+  - DONE using topn: archiving old players
   - DONE: more work on top-n rankings
   - /mines wguard - worldguard hints for mines (generate scripts to run?) - Use patterns that can be edited
 
@@ -114,6 +140,8 @@
 
 - Mine Resets - Glass block not being removed - harold
 
+
+
 - DONE?:  Archive old players - budderman18
   - archive all player files to a zip. Remove the originals. If player logs back on, then restore the archives. Prevent startup from adding these players back.
   - Archiving players in topN - this may address the archive needs.  Part of the issue was related to performance calculations upon startup, which the new topn does address.
@@ -248,6 +276,47 @@ https://github.com/Auxilor/EcoEnchants/blob/master/eco-core/core-plugin/src/main
 
 # Completed tasks
 
+
+
+- DONE: prison commands if using ; for multi-commands, and if a space follows ; then it's not working.
+
+
+- DONE: The command `/rankupmax` needs to be fixed - redonthehead
+  - DONE: `/rankupmax`, or `/rankupmax default` is fine, but replaced getting the next rank with the new code so it works better.
+  - DONE: `/rankupmax prestiges` is the same as `/prestige` and `/rankup prestiges`.  Change so it will go through the default ladder, then prestige, then repeat if enough money.
+
+
+- NOT AN ISSUE: In the GUI menu, the config setting: Enchantment_effect_current_rank is off by 1.  If D rank it shows E being unlocked. - CITYJD
+  - Looking at the code where this is used (player ranks and prestiges), the intention of this setting is to highlight the player's next rank.  So the settings name is wrong... It should be `Enchantment_effect_next_rank: true`
+  - Locate docs that covers this topic and make a note explaing what this is for and why the settings name is wrong.
+
+
+
+- DONE: Add `*all*` to `/mines set notification` - CITYJD
+ - Fixed a few other commands too to provide applying the command to all mines.
+
+
+
+- DONE: Force sellall before prestiges - kikiisyourfriend
+
+- DONE: Auto-Forced-Rankups and prestiges when the player has enough money.  Kikiisyourfriend
+ - a new autoFeatures entry
+
+- DONE: Enable Access to prior mines - kikiisyourfriend
+ - disable to prevent going back to prior rank mines.
+ - See `prison-mines.access-to-prior-mines` in config.yml
+
+
+- DONE: prison_rank__linked_mines_rankname prison_r_lm_rankname provide a placeholder for the mine's tags.  B0mer
+
+
+- DONE: Mines tp: option to list all available mines per rank? Thaysa
+
+
+- DONE: Option to skip applying the rank cost multiplier to a specific ladder.
+
+
+
 . DONE: Use of placeholders in gui mines is not working correctly - PassBl
  - Trying to use: - '&7Test Cost P1:  &3%prison_rank__player_cost_formatted_p1%'
  - Using deluxe menus - may not be sending player info with placeholders?