Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed code for project environment #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ivanhub
Copy link

@ivanhub ivanhub commented Oct 4, 2017

not rmrevin not processfast are working in projects
this code worked fine
I am changed preg replace so that html comments remover don't touch browsers [IF] conditions tags.

@ivanhub ivanhub closed this Oct 4, 2017
@stancel stancel reopened this Oct 4, 2017
@stancel
Copy link
Member

stancel commented Oct 4, 2017

Hi @ivanhub. This is an active project for us. I see that you opened this pull request eight hours ago and then closed it almost right away. We are open to taking pull requests on this open source project. On this pull request it looks like Scrutinizer has failed some tests though. We'll take a closer look at this and get back to you. Thanks.

@ivanhub
Copy link
Author

ivanhub commented Oct 9, 2017

You know that morning, I opened this request, by mistake, very sorry ...
I just made a fork of your project with some changes which is worked fine for me (to possibility for adding this modified extension to composer.json file of our yii2 project).
But also, if it does mean, I'll explain what I did and why, it is very simple...
Rmrevin extension didn't work on my standard advanced yii2 project (I was surprised, that there is still no good solutions for YII2..),
your (processfast) started to work on my project, but all JS and CS minified files created in binary, like mess of symbols (nor russian nor english...) same as binary file.
I don't know why, I did all by instructions. What is wrong I don't know. And actually I didn't have a time to try to debug it, or even create an issue what would of course is better.
Then I just replaced some files of your project with rmrevin and it started to work beautiful...
That's it.

@jaiminmoslake7020
Copy link

I am sorry for late reply. What we are doing in this that we are using gzencode function to Gzip compress all the JS and CSS files. So we can use GZIP of browsers to generate JS/CSS from compressed files. Right now we are not having any option to make it an optional thing. But yes in future we will have a config option that will allow users to choose to use Gzip compressing or not.

@jaiminmoslake7020
Copy link

One of the benefits of using GZIP compression is that our JS files of 1MB or greater and CSS files of 1MB or greater are now less than 100KB-200KB. Mostly are under 100KB. Which will help us load our assets faster in the browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants