-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize the RegisterFromNodeAnnotations code to make it clearer. Enhance its readability. #133
base: master
Are you sure you want to change the base?
Conversation
thanks for refining these code, have you tested? |
As a user for the k8s-vgpu-scheduler , I would suggest that @chaunceyjiang could add more UT for your code change to ensure that the new code is fully tested. |
I am currently testing. I will post the test results later. |
Good idea. However, this project currently lacks the corresponding GitHub action( golang-lint, UT, E2E, etc.), but I will supplement the UT later. |
|
Amazing! |
please resolve this conflict first :) |
…ance its readability. Signed-off-by: chaunceyjiang <[email protected]>
8549187
to
782e180
Compare
/cc @archlitchi PTAL. |
if
statements.