test: add TestValidateConfig()

[Kevindua26]

What type of PR is this?
/kind feature

What this PR does / why we need it:
Adds unit test coverage for the validateConfig() function in config.go. This function validates raw configuration before device initialization, checking that at least one device backend is configured, NVIDIA defaultCores is 0-100 percentage, and NVIDIA defaultMemory is not negative.

Which issue(s) this PR fixes:
Fixes #3154

Special notes for your reviewer:

This PR was prepared with assistance from GitHub Copilot.

Does this PR introduce a user-facing change?:
No

Summary by CodeRabbit

• Tests
  • Added coverage for scheduler configuration validation, including invalid core percentages, negative memory values, empty configurations, and valid settings.

[hami-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kevindua26
Once this PR has been reviewed and has the lgtm label, please assign archlitchi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

🧰 Additional context used

📚 Code guidelines (1)

CLAUDE.md — auto-discovered

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: a2825083-7d2e-4e8c-bef0-fdbdc2f1b63e

📥 Commits

Reviewing files that changed from the base of the PR and between 717f016 and 110db39.

📒 Files selected for processing (1)

• pkg/scheduler/config/config_test.go

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

---

📝 Walkthrough

Walkthrough

Added table-driven tests for validateConfig. The tests check empty configuration, out-of-range NVIDIA default cores, negative NVIDIA default memory, and a valid NVIDIA configuration.

Changes

Configuration Validation

Layer / File(s)	Summary
Test validateConfig pkg/scheduler/config/config_test.go	Added tests that assert errors for empty configuration and invalid NVIDIA defaults, and verify that a valid NVIDIA configuration succeeds.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: moezdil

Merge Risk: ⚪ Minimal · up to 110db

The change adds configuration-validation tests without changing runtime behavior; no merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely identifies the addition of the TestValidateConfig() unit test, which is the main change.
Linked Issues check	✅ Passed	Issue #3154 requests TestValidateConfig coverage for an empty configuration, NVIDIA defaultCores outside 0–100%, and negative NVIDIA defaultMemory. The added table-driven test checks each case and che…
Out of Scope Changes check	✅ Passed	The pull request adds only TestValidateConfig in pkg/scheduler/config/config_test.go. The test directly supports issue #3154. No unrelated changes appear in the whole-PR diff.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{A rabbit checks each setting with care
Empty and invalid values meet a test
Core limits stay within their bounds
Memory below zero gets a check
A valid config passes the way
Then hops along its merry way}

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag	Coverage Δ
unittests	77.33% <ø> (+0.07%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 3 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.