Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Fix the issue where scheduling can still occur on the node when the device-plugin crashes #322

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chaunceyjiang
Copy link
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #272

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@hami-robott hami-robott bot added kind/bug Something isn't working dco-signoff: yes labels May 27, 2024
@hami-robott hami-robott bot requested review from archlitchi and wawa0210 May 27, 2024 07:44
Copy link
Contributor

hami-robott bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chaunceyjiang
Once this PR has been reviewed and has the lgtm label, please assign archlitchi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hami-robott hami-robott bot added the size/L label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When the HAMI-device-plugin crashes, hami.io/node-handshake is still Requesting_.
1 participant