feat:Update k8s-device-plugin to v0.14.5 to Resolve nanoGPT Runtime Issue #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: haitwang-cloud The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
haitwang-cloud
force-pushed
the
upgrade-k8s-device-version
branch
from
6b48bc2
to
bef4d51
Compare
…sues with Hami and improve nanoGPT execution Signed-off-by: haitwang-cloud <[email protected]>
haitwang-cloud
force-pushed
the
upgrade-k8s-device-version
branch
from
bef4d51
to
499bb7b
Compare
haitwang-cloud
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
During an offline debugging session with @archlitchi , we identified that the current NVIDIA device plugin (v1.4.0) is causing compatibility issues with nanoGPT, preventing it from running properly. This issue persists even after setting CUDA_DISABLE_CONTROL to true and removing ld.so.preload from the GPU node.
We've confirmed that this problem also occurs in version 0.14.0 of the k8s-device-plugin. To resolve this, we need to update the k8s-device-plugin to at least version 0.14.5
/kind bug
What this PR does / why we need it:
This update is crucial for ensuring that our GPU resources are utilized effectively and that applications like nanoGPT can run without the encountered hindrances.
Which issue(s) this PR fixes:
Fixes # #347
Special notes for your reviewer:
I can not build the HAMi in my local env, so I am not be able to run the E2E testing , could u plz help to build a test img with this PR?
Does this PR introduce a user-facing change?:
No