Repository navigation
chore: bump amd-hami-core for the limit retry race fix - #146
Merged
Merged
Conversation
Picks up Project-HAMi/amd-hami-core#21: with no limit in the environment the per-allocation retry read /proc into a shared buffer outside the lock. Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: moezdil The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Bumps
amd-hami-coreto Project-HAMi/amd-hami-core#21. When no memory limit was in the environment, every allocation retried reading one through a helper that reads/procinto one static buffer withrealloc, outside the shared region lock, so concurrent allocations raced on it (ThreadSanitizer confirmed). The retry now runs under the lock. #21 also makes the on-GPUtest_memory_limitfail when a limit is not enforced. On an RX 9060 XT the rebuilt hook still stopshipMallocat the limit and grants 6 of 8 concurrent 600 MiB allocations under 4096 MiB.AI Disclosure:
AI assisted in writing this change.