feat: write cdf as json and settings as json #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
怎么就msvc编译能过啊XD |
|
msvc的模板实例化，是与别处不同的 |
|
果然与别处不同啊 |
| for (int compilerIndex = 0; compilerIndex < _compilerList.size(); ++compilerIndex) { | ||
| QJsonObject compilerObject = _compilerList[compilerIndex].toObject(); | ||
| for (int i = 0; i < _compilerList.size(); ++i) { | ||
| QJsonObject compilerObject = _compilerList[i].toObject(); |
There was a problem hiding this comment.
既然无论是i还是compilerIndex，表达的意思没有任何区别
那么就简单点好了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#69 #102