Skip to content

Commit 68038cb

Browse files
Improve tests per CodeRabbit suggestions
- Simplify test_cases to plain list (remove unused boolean) - Strengthen integration test with shape and value validations - Verify CT output range [0, 1] and single channel output Signed-off-by: Hitendrasinh Rathod <[email protected]>
1 parent e50560d commit 68038cb

File tree

1 file changed

+13
-14
lines changed

1 file changed

+13
-14
lines changed

monai/tests/test_clinical_preprocessing.py

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -99,20 +99,9 @@ def test_modality_case_insensitivity(mock_load):
9999
"""Test case-insensitive modality handling with whitespace trimming."""
100100
mock_load.return_value = Mock(return_value=Mock())
101101

102-
test_cases = [
103-
("CT", True),
104-
("ct", True),
105-
("Ct", True),
106-
("CT ", True),
107-
(" CT", True),
108-
("MR", True),
109-
("mr", True),
110-
("MRI", True),
111-
("mri", True),
112-
(" MrI ", True),
113-
]
114-
115-
for modality, _ in test_cases:
102+
test_cases = ["CT", "ct", "Ct", "CT ", " CT", "MR", "mr", "MRI", "mri", " MrI "]
103+
104+
for modality in test_cases:
116105
result = preprocess_dicom_series("dummy.dcm", modality)
117106
assert result is not None, f"Failed for modality: '{modality}'"
118107
result2 = preprocess_medical_image("dummy.dcm", modality)
@@ -156,6 +145,16 @@ def test_preprocess_dicom_series_integration(tmp_path):
156145
result = preprocess_dicom_series(str(test_file), modality)
157146
assert result is not None
158147
assert hasattr(result, "shape")
148+
assert len(result.shape) == 4 # (C, H, W, D)
149+
assert result.shape[0] == 1 # single channel
150+
151+
if modality == "CT":
152+
# CT output should be in [0, 1] due to ScaleIntensityRange
153+
assert result.min() >= 0.0
154+
assert result.max() <= 1.0
155+
159156
result2 = preprocess_medical_image(str(test_file), modality)
160157
assert result2 is not None
161158
assert hasattr(result2, "shape")
159+
assert len(result2.shape) == 4
160+
assert result2.shape[0] == 1

0 commit comments

Comments
 (0)