Skip to content

Conversation

@KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Mar 17, 2025

Workaround for Project-MONAI/research-contributions#411

Description

Skip PyTorch 2.6 test in auto3dseg

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@KumoLiu
Copy link
Contributor Author

KumoLiu commented Mar 17, 2025

/build

@KumoLiu KumoLiu requested a review from ericspod March 17, 2025 11:55
KumoLiu added 2 commits March 17, 2025 19:56
…hub.com>

I, YunLiu <[email protected]>, hereby add my Signed-off-by to this commit: 4039401

Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Mar 17, 2025

/build

@ericspod
Copy link
Member

How does this fix the issue? I had added explicit values for weights_only for torch.load in places in MONAI to make things compatible with Pytorch 2.6, all the tests passed at the time. If there's an issue with Auto3DSeg still we can possibly change the torch.load that's causing it.

@KumoLiu
Copy link
Contributor Author

KumoLiu commented Mar 17, 2025

Hi @ericspod, the error is from the algorithm used in auto3dseg in the rearsh contribution repo. Not related to the code in the core.
Project-MONAI/research-contributions#411

Signed-off-by: YunLiu <[email protected]>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Mar 19, 2025

/build

@KumoLiu
Copy link
Contributor Author

KumoLiu commented Mar 20, 2025

Should be resolved by this PR: Project-MONAI/research-contributions#412

@KumoLiu KumoLiu closed this Mar 20, 2025
@KumoLiu KumoLiu deleted the skip-auto-26 branch June 12, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants