Incorrectly states in tutorials train_controlnet #1919
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MaybeRichard <[email protected]>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
KumoLiu
approved these changes
Jan 13, 2025
Contributor
KumoLiu
left a comment
KumoLiu
left a comment
There was a problem hiding this comment.
Thanks for the fix, LGTM.
Contributor
|
Hi @MaybeRichard, could you please check the details of the fialed checks, then the PR can be merged, thanks! |
Contributor
Author
|
okay |
auto-merge was automatically disabled
April 9, 2025 01:32
Head branch was pushed to by a user without write access
for more information, see https://pre-commit.ci
Contributor
Author
|
Something wrong with the current version, I resubmitted a new pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description
The current documentation incorrectly states that "fold 0 is used for training" in the
prepare_maisi_controlnet_json_dataloaderfunction. In reality, the function uses thefoldparameter to determine the validation set based on matching fold indices. Specifically, if a dataset item'sfoldvalue matches thefoldvalue specified inconfig_maisi_controlnet_train.json, it is assigned to the validation set; otherwise, it is used for training.Changes
foldparameter to accurately reflect its functionality.fold 0is designated for validation andfold 1is designated for training.