Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use libtbb-dev/libtbb12 packages in Dockerfile-debian, sort packages alphabetically in both Dockerfiles #7095

Merged
merged 5 commits into from
Jan 12, 2025

Conversation

afarber
Copy link
Contributor

@afarber afarber commented Jan 11, 2025

Issue

Improve Dockerfile-debian and Dockerfile-alpine #7094

Changes

For Dockerfile-debian:

  • Use libtbb-dev in builder stage and libtbb12 package in runstage instead of building oneTBB v2021.12.0 from source code
  • Remove wget package from builder stage, because it is not used

For Dockerfile-alpine:

  • Update alpine:3.20.0 -> alpine:3.20.5

For Dockerfile-debian and Dockerfile-alpine:

  • Fix the warning "FromAsCasing: 'as' and 'FROM' keywords' casing do not match"
  • Sort packages alphabetically and put them on separate lines for easier comparison in future
  • Update the link to multi staged builds doc in the comment

…e instead of building oneTBB v2021.12.0 from source code

- Remove wget package from builder stage, because it is not used
- Uppercase "FROM ... as" -> "FROM ... AS" to silence a "docker build" warning
- Sort packages alphabetically and put them on separate lines for easier comparison
…not match"

- Sort packages alphabetically and put them on separate lines for easier comparison
@afarber
Copy link
Contributor Author

afarber commented Jan 11, 2025

@DennisOSRM and @SiarheiFedartsou could you please review my pull request for the master branch?

@afarber
Copy link
Contributor Author

afarber commented Jan 12, 2025

Maybe https://boostorg.jfrog.io/artifactory/main/release/1.85.0/source/boost_1_85_0.tar.gz is not reachable and that is why the OSRM backend CI error gzip: stdin: not in gzip format

@SiarheiFedartsou SiarheiFedartsou merged commit 6f235cc into Project-OSRM:master Jan 12, 2025
4 of 21 checks passed
@SiarheiFedartsou
Copy link
Member

Maybe https://boostorg.jfrog.io/artifactory/main/release/1.85.0/source/boost_1_85_0.tar.gz is not reachable and that is why the OSRM backend CI error gzip: stdin: not in gzip format

Most likely it is.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants