Fix json rendering of large osm ids #7096
Open
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imannamdari
force-pushed
the
fix-large-osmids-json-rendering
branch
from
e5df0c4 to
ef96e49
Compare
afarber
approved these changes
Jan 20, 2025
| @@ -54,7 +54,10 @@ template <typename Out> struct Renderer | |||
| // `fmt::memory_buffer` stores first 500 bytes in the object itself(i.e. on stack in this | |||
| // case) and then grows using heap if needed | |||
| fmt::memory_buffer buffer; | |||
| fmt::format_to(std::back_inserter(buffer), FMT_COMPILE("{:.10g}"), number.value); | |||
| if (static_cast<std::uint64_t>(number.value) == number.value) | |||
| fmt::format_to(std::back_inserter(buffer), FMT_COMPILE("{}"), static_cast<std::uint64_t>(number.value)); | |||
There was a problem hiding this comment.
Is the if/else block really needed? Can't a single line below handle the big integer number up to 18446744073709551615 (which is 2^64-1)?
fmt::format_to(std::back_inserter(buffer), FMT_COMPILE("{}"), static_cast<std::uint64_t>(number.value));
There was a problem hiding this comment.
Ah, nevermind, I see that it would break the fractional numbers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fix #7016
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?