Issue 6171 Make MAX_COLLAPSE_DISTANCE configurable in the lua profile #7252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaligrafy
force-pushed
the
issue6171
branch
from
9a86d39 to
0283967
Compare
kaligrafy
changed the title
Contributor
|
Thanks for your contribution, I have noticed that CHANGELOG.md is missing |
Author
|
Hi! Can any maintainer check this PR, it has been a month with no review. Thanks! |
Implements configurable max_collapse_distance parameter to address issue Project-OSRM#6171. This allows precise control over turn instruction collapsing in guidance, particularly important for pedestrian routing where short crossings need to be preserved for safety analysis. Changes: * Add max_collapse_distance property to ProfileProperties with getter/setter * Expose parameter to Lua scripting environment for profile configuration * Add GetMaxCollapseDistance() method to DataFacade interface * Replace hardcoded MAX_COLLAPSE_DISTANCE constant with thread-local variable * Update guidance collapse functions to use configurable parameter * Add documentation and example profile demonstrating usage The parameter defaults to 30.0 meters (preserving existing behavior) but can now be customized in Lua profiles: ```lua function setup() return { properties = { max_collapse_distance = 10.0, -- Custom value in meters }, } end ``` This enables sepcific usages who requires precise pedestrian routing instructions by preventing short road crossings from being collapsed into longer segments. Fixes Project-OSRM#6171 Developed with the help of Claude Sonnet 4 from Anthropic AI.
Author
|
I added the changelog entry as requested. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add configurable max_collapse_distance parameter to Lua profiles
Implements configurable max_collapse_distance parameter to address issue #6171.
This allows precise control over turn instruction collapsing in guidance,
particularly important for pedestrian routing where short crossings need
to be preserved for safety analysis.
Changes:
The parameter defaults to 30.0 meters (preserving existing behavior) but can
now be customized in Lua profiles:
This enables sepcific usages who requires precise
pedestrian routing instructions by preventing short road crossings from
being collapsed into longer segments.
#6171