This repository was archived by the owner on Feb 3, 2025. It is now read-only.
Remove duplicate keys: CameraDeviceClient.cpp#1
Open
karthick-kk wants to merge 517 commits intoProject-PixelStar:14from
Open
Remove duplicate keys: CameraDeviceClient.cpp#1karthick-kk wants to merge 517 commits intoProject-PixelStar:14from
karthick-kk wants to merge 517 commits intoProject-PixelStar:14from
Conversation
added 30 commits
January 26, 2023 04:22
Change-Id: I3fb111b11aa3faefc2473e2ad9278d6a00b8eced
Change-Id: Ic4e2e20c47ab3588d2c2cc4fcd6e0b23c5faf86f
Change-Id: Icaf428e7934debcf286ecd53ee586e5114c9d993
Change-Id: Idc141a697583da6a56820a517777a0c3acedc795
Change-Id: I85c3de39ae961002c642615b30836de6fa61eabd
Change-Id: I6905bcbc6b101769c7119d3bd548cb4ab88bdac9
Change-Id: Iac28f723eef45e595e19ee5cdcf8758865143467
Change-Id: I004d71b5621abdc0ae634ce72367ba96cb0e9e57
Change-Id: Id8b24a4894b463995e462d81a49dc90f993a41a0
Change-Id: Ie7932df7df6643b1cdb3b763e55b66daa70055ea
Change-Id: I601a29eb97eb53160dca951a94f8d44ea75366f2
Change-Id: If7c83635556004e7b18a61d7af74619dc04a0b5b
Change-Id: I4ff0c41a18ea9129dc3c7e233dec716d1853f973
Change-Id: I21e9e45c47432f3651ba3bd319070314a90dd638
Change-Id: I674ca0f7b926a3d4a2432f6b2d8bec1e4359191f
Change-Id: Ic4d31d037625e8ae77e0d14e91dc1800149e2448
Change-Id: I1b1887d99962a0da27076ed9cf2ef57c1c686383
Change-Id: I486fbd4c3bd2465b9843593c23645d68cc8b6147
Change-Id: Idc7daa3a896b2552d9aab274cc79ca2159114c03
Change-Id: I007378b7a9300dc470e47d0e0a130179d47d8fef
Change-Id: I76fd9bf50f88a76b61570be1edc98b40069d091f
Change-Id: Ib851075624e91f8e83674cfe894977eaff6daa0b
Change-Id: I4588824f867dc9c92487506390646c8615b212da
Change-Id: I3244c7e253d9c294e3be2725ef27cc143d734e4d
Change-Id: Id763921f3ae3c7a9002add375685afad43a34348
Change-Id: Ib028b94bdebb689a1a57fad512c261b7229fd733
Change-Id: I11e6c620006015deadbe943fac4089b488d37fa1
Change-Id: Ibe811123e6110c0bc456caa3c45f7bc56f9c07eb
Change-Id: I11c838c1ddfa467498a2dcf7ede3cdc5e76ae4c5
Change-Id: I3cb678ab11c1d260917561592b511cb5c99067b9
Sometimes when two client create a effect with the same session id，they will share the same effect BundledContext. If the two client release effect, the bundledContext will be release twice, which will cause crash. If one client is using the effect , the other client release the effect , also will cause crash. To avoid process crash, add reference count when effect create and release. Bug: 272310212 Test: vts VtsHalAudioEffectV7_0TargetTest Change-Id: I1d097dd5d2801fa3879c1ec4d099047700f0f841
Some HAL implementations return INVALID_OPERATION when set_volume isn't supported. Currently, this log would get printed every iteration of the audio loop. Since AudioFlinger will fallback to software-based volume control, to prevent log spam, don't log this error. Test: Manual, logging removed. Change-Id: I5d06fadbcbec105fbec6289f8c03db1451cc46be
Test: compiles Bug: 282476236 Bug: 281825210 Change-Id: Iceb776a259205ff414e843551156c908020cafa3
The current checkCompatibleAudioProfile routine preferences higher bit
depth over sample rate and channel count, and considers a request
compatible even if the number of channels in the profile is less than
the number of channels requested (see checkCompatibleChannelMask match
score). As a result, if a client requests 16-bit/48kHz/8-ch, and the
mixPorts support both 16-bit/48kHz/8-ch and 32-bit/16kHz/2-ch, the
32-bit lower channel count mixPort will be picked, resulting in missing
audio channels in the capture. For now, check if an exact audio profile
exists and prefer that over the compatible audio profile match; later
CLs may update checkCompatibleProfile to preference better channel
matching over preferring higher format bit depth.
Test: 16-bit/48kHz/8-ch exact match profile is picked even if a
compatible 32-bit/16kHz/2-ch profile exists.
Change-Id: I3dd0876d971f77dc358d6628e28472a231b235e4
This insures flush is handled properly for multichannel PCM tracks, etc. Test: see bug Bug: 283221159 Change-Id: I81fc17cb50b06f7e5df1caf1958bb480d1675fcb
Bug: 275022246 Test: Multiple use case of audio playback on Pixel phone Change-Id: I4e2aad9e499d7746c9be34de834c07eded5de76b
Bug: 289885996 Test: atest AudioPlaybackConfigurationTest with setprop audio.offload.min.duration.secs 1 (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:9d7c6f8f6649574362e087641a7b50805294a07c) Merged-In: I93c3a507eb3f9146ff8d80ce5f34ea0e46a49e5a Change-Id: I93c3a507eb3f9146ff8d80ce5f34ea0e46a49e5a
When creating a new track the thread lock is being held. This can have the effect of causing a deadlock when the OpPlayAudioMonitor is being created since the onFirstRef method could also try to access the same thread lock. Removing the broadcast when calling onFirstRef which is not needed and would also avoid the deadlock Test: atest AudioPlaybackConfigurationTest Bug: 289885996 (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:d585959ccce748ba024c63d09b08d737eabfc70a) Merged-In: I16555608176f1b1dfa180e82346319b55c19de01 Change-Id: I16555608176f1b1dfa180e82346319b55c19de01
…om new device. SHENNONG-8068 if device is change from none to new device, need get index from new device. Change-Id: Iaf88052e0e40efc5dbe19b1225fc3e0e3674af41 Signed-off-by: chenxin20 <chenxin20@xiaomi.com>
Test: atest MediaPlayerTest#testGapless2 Bug: 288611564 Change-Id: Ib75b0b2c385e8ef61e858282dbbf84e6d0997090
Test: m media_player_service_fuzzer && adb sync data && adb shell /data/fuzz/arm64/media_player_service_fuzzer/media_player_service_fuzzer Bug: 289674996 Change-Id: I3f31abc324914725f106fbdbab65922c741bf980
cblk will be released when the function isTrackAllowed_l returns false, so when creating PatchTrackBase we should check whether the cblk is released to prevent null pointer dereferencing issue. Test: make libaudioflinger Bug: 290325983 Change-Id: I2a61b5b4f7777528cd4f8f2aa80dfec113bfce2e Signed-off-by: gaoxiupei <gaoxiupei@xiaomi.corp-partner.google.com>
When property audio.deep_buffer.media is true, the deep buffer flag should be added if getOutput() parameter is music stream for getting correct track buffer size. Bug: 285222536 Test: adb shell "am instrument -e class android.media.audio.cts.AudioTrackTest#testPlaybackHeadPositionIncrease -w -r android.media.audio.cts/androidx.test.runner.AndroidJUnitRunner" Change-Id: I896a9b1807ec6ae512344d8a1e3e681806bbff22 (cherry picked from commit 75563d3)
Causes output stuttering with global aux effects such as environmental reverb. Test: see bug Bug: 284258913 Change-Id: I32132f3b52c655ab350715df7097d63adc0ce9c3
This workaround was introduced in 2014 [1]. At the time it was correctly only comparing audio timestamps because mAnchorTimeMediaUs only held audio timestamps then. In 2017 [2], mAnchorTimeMediaUs started to hold video timestamps too - at which point this comparison became invalid and a bug was introduced that can lead to control-flow exiting too early when handling an audio buffer with the same timestamp as the preceding video buffer. If this happens at the start of playback, then the **second** audio buffer timestamp is passed to MediaClock::setStartingMediaTime, which can lead to incorrect values being returned from NuPlayerRenderer::getCurrentPosition (when paused at the start of playback). [1] https://cs.android.com/android/_/android/platform/frameworks/av/+/eecb7805bbbb712925d4372c505f8c7f5c4fb5ed [2] https://cs.android.com/android/_/android/platform/frameworks/av/+/17648f365e5914fa772bbfebaf9f5c6a37ddfb99 Test: atest MediaPlayerTest Bug: 283882552 Bug: 282472894 Bug: 263063118 Change-Id: I7fbe6bdaff27c93f15d9d85902306a3f6e00b978
When the effect for doing volume control is changed, set volume for the old one as full level and the new one as 0 for safe ramping. Bug: 280641126 Test: repo steps in the bug Change-Id: I0f843c8deae907f8584dc18d025ab499319784b5 Merged-In: I0f843c8deae907f8584dc18d025ab499319784b5
1. setOutputDevice() is implemented by restoring track, let track to do re-creation so that setOutputDevice can work on direct and offlaod track. 2. Since mRoutedDeviceId will not be updated immediatly when default device in policy is changed, do not check mRoutedDeviceId in setOutputDevice(). Bug: 297164626 Test: Manual Change-Id: I323a6bbf7be9f757851d3adf25681d034deb8b22 Signed-off-by: minaripenguin <minaripenguin@users.noreply.github.com>
* fixes vtservice cpu hogging Change-Id: Ief25e83c5b4d40e56da8487eef52574a969af9ca
* big brained realmeme decided to move aux cams to "system-only cameras" utilizing the new permission introduced in android 11, thereby breaking aux cams in 3rd party camera apps like gcam * lets avoid this and make system camera accessible to all camera apps; legacy apps still wont break because of the aux cams check in fwb Test: manual, aux cameras accessible by gcam on realme X3 Change-Id: I5db53ffe91a8c28972f1c58bd228cb0f79d7183a Signed-off-by: Adithya R <gh0strider.2k18.reborn@gmail.com> Signed-off-by: S I P U N <sipunkumar85@gmail.com> Signed-off-by: mukesh22584 <mks22584@gmail.com>
This is a squashed commit of the changes added to support extended feature in audiopolicymanager and related error. Only some parts of the fixes have been ported as the custom audio policy has the other required changes. audiopolicy: support extended feature in audiopolicymanager audiopolicy: additional change for extended feature audiopolicy: Add voip flag to output flag list Change-Id: I7738d4b0ac11ee6d93bfd67e2553eae8518ff719 audiopolicy: follow-up change to support extended feature Change-Id: Iddc14a3e2e61bc57f8637eae71e36cc21ce2d3e8 [dianlujitao: Port to R] CRs-Fixed: 2208307 Change-Id: Icc12395480cfe5e26bf935fb643d080990d8a4e9 Signed-off-by: S I P U N <sipunkumar85@gmail.com> Signed-off-by: mukesh22584 <mks22584@gmail.com>
* Aligned with CAF as of QSSI12, and removed unnecessary devices.isEmpty() check. Original patch: https://source.codeaurora.org/quic/la/platform/frameworks/av/commit/services/audiopolicy?h=LA.BR64.1.1.1-01010-8x16.0&id=9cc970fc512bedfa6a2cf03457d93609adc6eb85 Change-Id: I9bad6a294ddd7aee72f6f6a314666b892b730c8e Signed-off-by: S I P U N <sipunkumar85@gmail.com> Signed-off-by: mukesh22584 <mks22584@gmail.com>
Because the delay buffer size is fixed, the buffer would overflow if there are many frames in the input buffer. The buffer should be dynamically allocated according to the input. - Replace fixed-size ring buffer with dynamic buffer list. - Improve delay buffer copy codes. Bug: 259816867 Change-Id: Ia66755b5478e6e72089b51dbe8e3d2e7b086e5ad Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Currently, we have static 10 ms delay to fetch back the decoder input buffers for all usecases when the queue is empty. For HFR usecases (>480 fps), fetching back the input buffers after 10ms is leading to the stalls in input buffer pipeline and so the performance issue is observed. Hence update the fetch delay as a function of operating rate to speed up the pipeline delay. Bug: b/208475704 Change-Id: I95163d3d05721cc0a12ee9f486a7d3a3b8b8a600 Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
In NuplayerDecoder, after MediaCodec::configure() returns success, it is assumed that MediaCodec is in CONFIGURED state. But, after MediaCodec::configure() has returned success, there are some race conditions in CCodecWatchdog thread that can move MediaCodec to error state after configuration. So, errors from MediaCodec::getInputFormat() and getOutputFormat() need to be handled cleanly instead of assert checks. This removal of assert check is temporary fix to avoid tombstones till the race condition is fixed in CCodec. CRs-Fixed: 3538169 Change-Id: Ibecef88019f3c273aeec16ddd29aeffbfbf5c333 (cherry picked from commit bf63b70591409eb7ac39c392fe5adc772bb789c4) Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
This library is still intended to be fully visible. However LTO at certain GC opt levels changes visibility and breaks versioning. Best to just disable, especially given many ship prebuilts with dependencies here. Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Removed duplicate redefinition of PROPERTY_VALUE_MAX and packagelist in CameraDeviceClient.cpp
Remove duplicate keys: CameraDeviceClient.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed duplicate redefinition of PROPERTY_VALUE_MAX and packagelist in CameraDeviceClient.cpp