Automatic installation of GitHub CLI, Git and Git LFS #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add automated installation of GitHub CLI (if not available), Microsoft's Git and Git LFS in regards to the operating system (Windows, Mac OS)
Add "requests" and "urllib3" package to handle GitHub CLI download
User21T
changed the title
User21T
changed the title
mastercoms
requested changes
May 6, 2025
| except FileNotFoundError: | ||
| return False | ||
|
|
||
| def install_gh_cli(): |
There was a problem hiding this comment.
GitHub CLI is expected to be in .github/git/gh.exe, please see pbgh.py. Though, I suppose we need to do some work to fix support for GitHub CLI while using repos on GitLab, since it uses GitLab CLI automatically in that case. So maybe forcing GitHub CLI is good there.
| verboselogs = "*" | ||
| crcmod = "*" | ||
| tinyaes = "*" | ||
| requests = "*" |
There was a problem hiding this comment.
We use urllib.request in other places, so if we are including the requests package, we should probably avoid importing urllib.request throughout.
pbsync/__main__.py
Outdated
|
|
||
| default_config_name = "PBSync.xml" | ||
|
|
||
| retry_strategy = Retry( |
There was a problem hiding this comment.
Maybe make a new pbhttp module in pbpy?
Add separate module for handling HTTP requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added requests and urllib3 packages in the first place to handle downloading files from Internet via Python script. Then I have rewritten code in pbsync/main.py to allow PBSync for automatic installation of GitHub CLI, Microsoft's Git and Git LFS. For more information see ticket #7.
First, the program checks whether GitHub CLI isn't already installed. If yes, then it proceeds forward. Otherwise, it starts downloading installation file for GH CLI. When downloading fails once, the program will repeat the process 5 times at most until passing. If download and installation process is successful, then Git and Git LFS are installed via GitHub CLI and terminal commands.
Workflow is improved, because we don't download separately by a browser. We can also repeat the version check/install process. Since we are repeating GitHub CLI download process, we don't have to terminate it because of temporary problems like no Internet connection.