- 
                Notifications
    
You must be signed in to change notification settings  - Fork 14
 
          enhancement/issue 1317 import map generation refactor for exports and leveraging import.meta.resolve
          #1326
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            thescientist13
  merged 28 commits into
  master
from
enhancement/issue-1317-import-map-generation-refactor
  
      
      
   
  Dec 2, 2024 
      
    
                
     Merged
            
            
  
    enhancement/issue 1317 import map generation refactor for exports and leveraging import.meta.resolve
  
  #1326
              
                    thescientist13
  merged 28 commits into
  master
from
enhancement/issue-1317-import-map-generation-refactor
  
      
      
   
  Dec 2, 2024 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
    This was
    linked to
    issues
    Nov 27, 2024 
      
  
  Closed
  
      
        
      
      
  
    5 tasks
  
  This was referenced Nov 28, 2024 
      
b855aab    to
    42a3ae8      
    Compare
  
    …ing an import map
42a3ae8    to
    86f9c3c      
    Compare
  
    
      
        
      
      
  
    5 tasks
  
import.meta.resolve
      
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    breaking
  
    bug
  Something isn't working 
  
    CLI
  
    documentation
  Greenwood specific docs 
  
    enhancement
  Improve something existing (e.g. no docs, new APIs, etc) 
  
    feature
  New feature or request 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Related Issue
#1317 / #1309
Test repos (WIP)
Summary of Changes
import.meta.resolveinstead of hardcoding location for node_modules (helps with PNPM support (not hardcoding location of node_modules on disk) #1313)importfrom a directory #907importfrom a directory #907This will require a minimum NodeJS bump toUpgrade to latest Node LTS(s) #120220.xfor JSON Modules bug and will indirectly resolveDocumentation
/, always use relativebinentry point)- https://unpkg.com/browse/[email protected]/package.jsonTODOs
Bump NodeJS version to minimum version per -ERR_INTERNAL_ASSERTIONwith Strapi CLI nodejs/node#51354engines