Skip to content

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Jun 28, 2025

Related Issue

related to #1427

Documentation

N / A

Summary of Changes

  1. Enable full typecheck for the monorepo
  2. Resolved a few misc issues

TODO

  1. Verify change to Adapter types are compatible
  2. enable noImplicitAny per bug/issue 1518 fix the type for Greenwood CLI run function #1531
  3. Double check changes to init default options still work as expected
  4. Why is greenwood type config not catching plugin errors? - https://github.com/ProjectEvergreen/greenwood/pull/1524/files#r2173252332
  5. Upstream correct types into WCC

@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) Plugins Greenwood Plugins CLI Types(cript) Requires type definition or TypeScript related work / documentation labels Jun 28, 2025
@@ -65,7 +65,7 @@ const config: Config = {
greenwoodPluginGraphQL(),
greenwoodPluginImportCommonJs(),
greenwoodPluginImportJsx(),
greenwoodPluginImportRaw,
greenwoodPluginImportRaw(),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this doesn't error out? Even putting in a string here seems to bork out plugins, but just plugins it seems?
Screenshot 2025-06-28 at 9 36 33 AM

But in a standalone project, it does work as expected
Screenshot 2025-06-27 at 8 20 45 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) needs upstream Plugins Greenwood Plugins Types(cript) Requires type definition or TypeScript related work / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update Greenwood to address all (as many) TypeScript no check comments
1 participant