Feature/issue 87 jsx coarse grained observability#94
Merged
thescientist13 merged 13 commits intomasterfrom Jan 4, 2023
Merged
Conversation
14941f4 to
9587335
Compare
9587335 to
14bfdc2
Compare
14bfdc2 to
3fd435f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #87
Summary of Changes
renderandconstructorfunctions for usages ofthisto generateobservedAttributesandattributeChangedCallbackexport const inferredObservability = {boolean}For example, this
Would produce this
Use it as
Very simple implementation right now mostly as a nice way to do basic text updates / substations, as can be seen in thescientist13/greenwood-counter-jsx#3
TODOs
attributeChangedCallbackwith fine grained observabilityexportto opt-in / outthisstate - all being tracked in LiteralthisEvaluation and Derivative References #88inferObservability)Questions / Observations (follow up issues / discussions)
renderfunction up front before we parse and / or add instruction sets? - yes, I think we do this nowrenderandconstructor? Or just infer fromrender()only? - Will just userenderfunction for nowobservedAttributesorattributeChangedCallbackexists, and merge? Or defer to what already exists? Explicit Opt-in / out?